Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archived rules checkbox and text #1198

Merged
merged 8 commits into from
Feb 5, 2024

Conversation

jeoffreyfischer
Copy link
Member

@jeoffreyfischer jeoffreyfischer commented Jan 4, 2024

Pain
As per my conversation with @adamcogan, the archived rules are only accessible on a separate page.
It would be good to see all the rules in the same page (archived and unarchived).

Solution
A checkbox has been added at the top of the page to display archived rules.
The archived rules have a "archived" tag to be differentiated from the other rules.

Relates to #1196

Screenshots
rules-PR-003a
Figure: The new "Include archived" checkbox.

rules-PR-003b
Figure: When clicked, the archived rules are listed with a "Archived" badge.

@JackDevAU JackDevAU requested a review from tiagov8 January 4, 2024 23:55
@@ -150,6 +155,17 @@ export default function Category({ data }) {
labelText="Gimme everything!"
icon={faBook}
/>
<div className="rule-category-checkbox">
Copy link
Member

@JackDevAU JackDevAU Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should make archived rules more searchable? We currently have https://www.ssw.com.au/rules/archived/

But would like to hear @tiagov8 thoughts!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @JackDevAU

Copy link
Member Author

@jeoffreyfischer jeoffreyfischer Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this feature is very useful at the moment as we are migrating rules and deciding whether they should be archived or not. Maybe once all the rules are migrated we can remove the feature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @JackDevAU and @jaydenalchin

This feature gives unnecessary visibility to outdated content.

I know @adamcogan asked for it... but what is the goal with this?

Copy link
Member Author

@jeoffreyfischer jeoffreyfischer Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my conversation with @adamcogan, this feature is turned off by default, so it is not visible at page load. The goal is to allow users to view archived rules if they want to. And it is also a very useful feature as we are currently migrating rules from the old to the new website.

Copy link
Member Author

@jeoffreyfischer jeoffreyfischer Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my conversation with @adamcogan, he explained to me that this feature is actually important because we currently do not have a direct access from a rules category page to the related archived rules.

As some concern was raised in this conversation by @tiagov8 , @jaydenalchin and @JackDevAU , once the feature is live I will run analytics on it to see whether it's being used or not.
If we realise that it is unpopular, we will discuss its use again.

I have prepared a "To myself" email that I will send to all of us once the feature is live, subject "Rules category - run analytics on buttons and checkbox"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeoffreyfischer / @adamcogan

See this related Isuue comment: #934 (comment) (the full issue is quite long)

Basically if we make the Archived page to show rules by category (as the regular rules), we solve the problem without having to mix archived/live rules up...

IMO it is a way better solution!

Let me know if in doubt.


once the feature is live I will run analytics on it to see whether it's being used or not.
If we realise that it is unpopular, we will discuss its use again.

I am pessimistic about the possibilites with this... no matter the results, this feature will be there for good 🙁 I think the best way to avoid a bad feature is to not implement it.

Copy link
Member

@jaydenalchin jaydenalchin Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record if this has to be a feature I'd prefer it be a link to the Archived Rules page at the bottom of a category e.g. "Can't find what you're looking for? See Archived Rules".

Edit: Big +1 to Tiago's comment above, especially the final comment. Popularity has little to do with why this feature is a problem.

Copy link
Member

@JackDevAU JackDevAU Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I'm with Jayden and Tiago on this one, once this feature is in it'll never be removed again (until the rewrite of Rules... 😅) But as this is something the Product Owner wants - I can't block this feature being implemented :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my conversation with @adamcogan, I explained to him the alternative solutions proposed by @jaydenalchin and @tiagov8 and proposed him to set a meeting with all of us to discuss this.
He decided to keep going with the initial plan i.e. the checkbox to display archived rules. The reason being that none of the 2 options provide a direct access from a rules category page to the respective archived rules category.
Given this requirement, I also agree that the initial solution is the best.

@tiagov8 tiagov8 requested a review from JackDevAU January 29, 2024 19:36
Copy link
Member

@jaydenalchin jaydenalchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the Product Owner is adamant - for the record I still think this is a terrible feature.

@jeoffreyfischer jeoffreyfischer merged commit a7a8af6 into main Feb 5, 2024
5 checks passed
@jeoffreyfischer jeoffreyfischer deleted the 1196-archived-rules-checkbox-and-text branch February 5, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants