Updated Page Title #1223
Merged
Updated Page Title #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackDevAU
reviewed
Jan 23, 2024
| </Helmet> | ||
| ); | ||
| }) => { | ||
| const isHomePage = location.pathname === '/'; |
There was a problem hiding this comment.
I feel this might need an ? as location might be undefined during build
Suggested change
| const isHomePage = location.pathname === '/'; | |
| const isHomePage = location?.pathname === '/'; |
There was a problem hiding this comment.
well I guess it did build in staging... so maybe disregard these :P
There was a problem hiding this comment.
yes, the location is populated by Gatsby, so it should be present during build 🙂
JackDevAU
reviewed
Jan 23, 2024
| }; | ||
|
|
||
| const pageTitleFull = setFullTitle(); | ||
| const canonical = parentSiteUrl + (location.pathname || ''); |
There was a problem hiding this comment.
Suggested change
| const canonical = parentSiteUrl + (location.pathname || ''); | |
| const canonical = parentSiteUrl + (location?.pathname || ''); |
same with here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1159
Change: