Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Renamed storage account param name to match with the bicep param #1550

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Oct 8, 2024

cc: @tkapa @bradystroud

After creating a new release/141 from main, the Deploy Infra job was failing due to recent changes into main to support tina migration.
This pull request includes a small change to the .github/workflows/template-deploy.yml file.
Note: I will be deleting new created release branch for now.

  • .github/workflows/template-deploy.yml: Renamed storageAccountName to customStorageAccountNames in the deployment script so it matches with the main.bicep params list.

image
Figure: Deploy Infra failing - https://github.com/SSWConsulting/SSW.Rules/actions/runs/11231860515/job/31223250760

@babakamyljanovssw babakamyljanovssw changed the title fixed param name when passing to bicep Fixed storage account param name when passing to bicep Oct 8, 2024
@babakamyljanovssw babakamyljanovssw changed the title Fixed storage account param name when passing to bicep Fixed storage account param name to match with the bicep param Oct 8, 2024
@babakamyljanovssw babakamyljanovssw changed the title Fixed storage account param name to match with the bicep param ♻️ Renamed storage account param name to match with the bicep param Oct 8, 2024
@babakamyljanovssw babakamyljanovssw merged commit 58829f6 into main Oct 9, 2024
6 checks passed
@babakamyljanovssw babakamyljanovssw deleted the fix-main-deploy-infra branch October 9, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants