Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Insights - Switched from instrumentation key to connection string #1558

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Oct 12, 2024

Relates to #1522

This pull request involves updating the configuration for Application Insights across multiple files to use a connection string instead of an instrumentation key. Additionally, it includes a minor version update for the applicationinsights package in package.json.

Note: Added new APPLICATIONINSIGHTS_CONNECTION_STRING to production and staging environments

Application Insights Configuration Update:

  • .github/workflows/template-build.yml: Changed APPINSIGHTS_INSTRUMENTATIONKEY to APPLICATIONINSIGHTS_CONNECTION_STRING.
  • gatsby-browser.js: Updated the configuration to use connectionString instead of instrumentationKey.
  • gatsby-node.js: Modified the environment variable check and warning message to use APPLICATIONINSIGHTS_CONNECTION_STRING.
  • Various component files: Updated the Application Insights configuration to use connectionString:
    • src/components/acknowledgements/acknowledgements.js
    • src/components/bookmark/bookmark.js
    • src/components/comments-not-connected/comments-not-connected.js
    • src/components/header/header.js
    • src/components/profile-content/profile-content.js
    • src/components/reaction/reaction.js
    • src/components/sidebar-categories/sidebar-categories.js
    • src/components/signin/signin.js
    • src/pages/orphaned.js
    • src/pages/profile.js
    • src/pages/user/index.js
    • src/templates/category.js
    • src/templates/rule.js

Dependency Update:

  • package.json: Updated @microsoft/applicationinsights-web from ^3.3.2 to ^3.3.3 and applicationinsights from ^3.2.1 to ^3.3.0.

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babakamyljanovssw babakamyljanovssw merged commit f0c58d4 into main Oct 14, 2024
5 checks passed
@babakamyljanovssw babakamyljanovssw deleted the 1522-app-insights branch October 14, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants