Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔁 App Insights - Added condition to mark google analytics logs with 0 code as success #1593

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Oct 25, 2024

Relates to #1589

This pull request includes a small change to the useAppInsights hook. The change ensures that Google Analytics logs with a response code of 0 are marked as success. The reason I explained in this comment #1589 (comment)

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Baba - can you also update the PR title to reflect these requests aren't being 'filtered out' :)

@babakamyljanovssw babakamyljanovssw merged commit 9a65312 into main Oct 28, 2024
5 checks passed
@babakamyljanovssw babakamyljanovssw deleted the 1589-google-analytics branch October 28, 2024 04:14
@babakamyljanovssw babakamyljanovssw changed the title 🔁 App Insights - Added filter to filter out google analytics with 0 code 🔁 App Insights - Added condition to mark google analytics logs with 0 code as success Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants