Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Removed extra space between rule content and Giscus #1669

Merged
merged 9 commits into from
Jan 24, 2025
Merged

♻️ Removed extra space between rule content and Giscus #1669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
85277e7
removed extra space between rule content and giscus
babakamyljanovssw Jan 15, 2025
2554273
keep prev style for line
babakamyljanovssw Jan 15, 2025
f2886da
clean up
babakamyljanovssw Jan 21, 2025
0bda21e
Merge branch 'main' into remove-space
babakamyljanovssw Jan 21, 2025
2317982
used hr to break line
babakamyljanovssw Jan 22, 2025
6317a99
Merge branch 'remove-space' of https://github.com/SSWConsulting/SSW.R…
babakamyljanovssw Jan 22, 2025
8fe0b7e
Update rule.js
tiagov8 Jan 22, 2025
ff413e0
moving hr tag to it's prev container
babakamyljanovssw Jan 23, 2025
ddac6f1
Merge branch 'remove-space' of https://github.com/SSWConsulting/SSW.R…
babakamyljanovssw Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/discussion/discussion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import PropTypes from 'prop-types';

const Discussion = (props) => {
return (
<div className="discussion-box">
<div className="discussion-box mb-20 px-6 pb-4">
<Giscus
id="comments"
repo={process.env.GISCUS_REPO_NAME}
Expand Down
19 changes: 0 additions & 19 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,25 +1141,11 @@ div.bad-example {
box-shadow: 0 5px 40px rgba(0, 0, 0, 0.25);
}

#more {
/* overflow: auto; */
text-align: center;
border-top: 1px solid #f5f5f5;
}

.acknowledgements h5, .tags h5, .likes h5 {
margin-top: 2rem!important;
margin-bottom: 0.5rem!important;
}

#more .acknowledgements .avatar img {
max-width: 75px;
}

#more .acknowledgements .avatar a, #more .acknowledgements .avatar a:hover {
border-bottom: none;
}

.info-btn-container {
margin-top: 1.65rem;
text-decoration: none !important;
Expand Down Expand Up @@ -1761,11 +1747,6 @@ div.bad-example {
border-top: 1px solid #f5f5f5
}

.discussion-box {
margin-bottom: 5rem;
padding: 1rem 1.5rem;
}

.discussion-box h3 {
color: #cc4141;
}
Expand Down
6 changes: 2 additions & 4 deletions src/templates/rule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,8 @@ const Rule = ({ data, location }) => {
)}
<hr />
<div dangerouslySetInnerHTML={{ __html: rule.html }} />
<section
id="more"
className="mt-12 flex flex-wrap pt-6 pb-6 lg:pb-12 text-center -mb-6"
></section>

<hr />
</section>

<div className="lg:hidden md:w-1/1 px-4">
Expand Down
Loading