Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏎️ Performance - Media Query Dynamic Import Experiment #2151

Closed
wants to merge 11 commits into from

Conversation

Harry-Ross
Copy link
Contributor

@Harry-Ross Harry-Ross commented Feb 16, 2024

  • Testing a dynamic import of carousel based on media query, which should reduce the bundle size on mobile devices
  • Affected routes:

  • Fixed #{{ ISSUE NUMBER }}

  • If adding a new page, I have followed the 📃 New Webpage issue template

  • Include done video or screenshots

Copy link
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 78
Performance 37
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 78
Performance 28.000000000000004
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 78
Performance 32
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 74
Performance 37
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 74
Performance 28.999999999999996
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.26% 69/26612
🔴 Branches 8.99% 24/267
🔴 Functions 1.22% 3/246
🔴 Lines 0.26% 69/26612

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from e5ad553

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

Copy link
Contributor

github-actions bot commented Mar 8, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 34
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2151.azurewebsites.net

@Harry-Ross
Copy link
Contributor Author

Closing this PR as changes have been made in #2253 applicable to performance scores

@Harry-Ross Harry-Ross closed this Mar 18, 2024
@amankumarrr amankumarrr deleted the bundle-size-experiment branch September 16, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant