Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔎 SEO - Fix SEO on Homepage + Events #2253

Merged
merged 68 commits into from
Mar 18, 2024
Merged

🔎 SEO - Fix SEO on Homepage + Events #2253

merged 68 commits into from
Mar 18, 2024

Conversation

Harry-Ross
Copy link
Contributor

@Harry-Ross Harry-Ross commented Mar 8, 2024 •
edited
Loading

  • Converted imported components in blocks-renderer.tsx and mdxComponentRenderer.tsx to use next/dynamic as per https://www.ssw.com.au/rules/dynamically-load-components/
  • 🎉 Added React Query to /events to allow loading more events if required, reduces the amount of data shipped to the page, better caching functionality, now has infinite scroll
    • Added pagination to events API routes
  • Added useReportWebVitals to the layout to report web vitals (e.g. FCP, CLS) to App Insights
  • Added memo to component that was unecessarily rerendering on homepage (flickering)
  • Restructured carousel components to dynamic import react-responsive-carousel and made base size of carousel div to avoid layout shifts when images load in
  • Used image "sizes" (https://nextjs.org/docs/pages/api-reference/components/image#sizes) to reduce the file size of images, added to some MDX components for better fine grained control
  • Changed service cards to not use rich-text, as its just a string
  • Fixed references to events page with old query string (/events?tech=all&type=all)
  • General cleanup i.e. adding props to elements, changing from function model to React component model
  • Changed CSS background images on pages to use getImageProps, which means they can use the features of next/image
  • Added aria-label to social icons
  • Fixed sitemap to not reference the v1 site, got useful non-v3 URLs from sitemap and made an additional site
  • Fixed sitemap to use real index, not /home
  • Upgraded ssw.megamenu package from 4.2.2 to 4.5.3
  • Added caching for API route /api/get-megamenu
  • Changed from query string manual schema validation to using yup
  • Fixed canonical URL for /clients pages
  • Added priority loading for LCP elements (i.e. carousel)
  • Fixed hydration issue on /offices pages with testimonials

Before (mobile):
image

After (mobile):
image

Before (desktop):
image

After (desktop):
image

Load more on /events
image

@Harry-Ross Harry-Ross changed the title 🔎 SEO - Fix SEO Pages Throwing Errors 🔎 SEO - Fix SEO Pages on Throwing Errors Mar 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 0.25% 69/27485
🔴 Branches 8.89% 24/270
🔴 Functions 1.2% 3/249
🔴 Lines 0.25% 69/27485

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 1b3619e

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.999999999999996
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.999999999999996
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.999999999999996
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 35
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@Harry-Ross Harry-Ross marked this pull request as ready for review March 15, 2024 04:59
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 37
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

amankumarrr
amankumarrr reviewed Mar 15, 2024
View reviewed changes
amankumarrr
amankumarrr reviewed Mar 15, 2024
View reviewed changes
@Harry-Ross Harry-Ross requested a review from amankumarrr March 15, 2024 06:44
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 38
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 40
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@Harry-Ross Harry-Ross mentioned this pull request Mar 18, 2024
Closed
2 tasks
amankumarrr
amankumarrr approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 49
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2253.azurewebsites.net

@Harry-Ross Harry-Ross merged commit aadd0d2 into main Mar 18, 2024
11 checks passed
@Harry-Ross Harry-Ross deleted the 2248-fix-events branch March 18, 2024 23:06
@Harry-Ross Harry-Ross mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amankumarrr amankumarrr amankumarrr approved these changes

@wicksipedia wicksipedia Awaiting requested review from wicksipedia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔎 SEO - Make SEO Fixes
2 participants
@Harry-Ross @amankumarrr