Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Adam's image on home page #2347

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fixing Adam's image on home page #2347

merged 1 commit into from
Mar 21, 2024

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Mar 21, 2024

Renaming the image name fixes the issue.

  • Affected routes: /
image

Figure: Homepage - Before the change

image

Figure: Homepage - After the Change

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.25% 69/27520
🔴 Branches 8.89% 24/270
🔴 Functions 1.2% 3/249
🔴 Lines 0.25% 69/27520

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from ce42f8e

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2347.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 35
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2347.azurewebsites.net

@amankumarrr amankumarrr enabled auto-merge (squash) March 21, 2024 04:10
Copy link
Member

@jeoffreyfischer jeoffreyfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - I will talk to Ken regarding the apparent different margin for each image, likely due to the extra white space in the Microsoft Logo image.

@amankumarrr amankumarrr merged commit 67e83f6 into main Mar 21, 2024
11 checks passed
@amankumarrr amankumarrr deleted the fixing-homepage-image branch March 21, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants