Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration - Typography page #2353

Merged
merged 16 commits into from
Mar 26, 2024
Merged

Conversation

andrewwaltosssw
Copy link
Member

@andrewwaltosssw andrewwaltosssw commented Mar 22, 2024

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.25% 69/27597
🔴 Branches 8.86% 24/271
🔴 Functions 1.2% 3/250
🔴 Lines 0.25% 69/27597

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 1fb6894

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 37
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 90
Best practices 96
Performance 42
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 90
Best practices 96
Performance 50
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, consider moving the carousel on the top and making a video component a bit wider.

This is version 1 of the page and we probably be doing some more changes in second part after getting designer's feedback.

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 40
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 90
Best practices 96
Performance 43
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net

@andrewwaltosssw andrewwaltosssw merged commit 62dea74 into main Mar 26, 2024
11 checks passed
@andrewwaltosssw andrewwaltosssw deleted the 2282-migrate-typography-template branch March 26, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📄Migration | Logo | SSW Typography page - Part 1/2 - Template
2 participants