-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration - Typography page #2353
Conversation
Coverage report
Test suite run success13 tests passing in 1 suite. Report generated by 🧪jest coverage report action from 1fb6894 |
Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, consider moving the carousel on the top and making a video component a bit wider.
This is version 1 of the page and we probably be doing some more changes in second part after getting designer's feedback.
Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2353.azurewebsites.net |
Create new Typography page with TODO for content
Affected routes:
/company/typography
Fixed 📄Migration | Logo | SSW Typography page - Part 1/2 - Template #2282
If adding a new page, I have followed the 📃 New Webpage issue template
Include done video or screenshots

Figure: New typography page