Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating NETUG to App Router #3647

Merged
merged 19 commits into from
Feb 27, 2025
Merged

Migrating NETUG to App Router #3647

merged 19 commits into from
Feb 27, 2025

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Feb 26, 2025 •
edited
Loading

✅ Migrated the NetUG pages
✅ Updated the Eslint's tailwind packages
✅ Fixed the lint issues
✅ Updating pnpm to 9.15.5 (Aligning with TinaCMS)

image
Figure: /netug page on PR slot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 0.19% 69/36814
🔴 Branches 5.97% 24/402
🔴 Functions 0.79% 3/381
🔴 Lines 0.19% 69/36814

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 2bd29a3

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 64
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 59
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 66
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@amankumarrr amankumarrr requested review from isaaclombardssw and babakamyljanovssw and removed request for isaaclombardssw February 27, 2025 00:45
@amankumarrr amankumarrr marked this pull request as ready for review February 27, 2025 00:46
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 55
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@wicksipedia
Copy link
Member

wicksipedia commented Feb 27, 2025 •
edited
Loading

https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net/netug/sydney - ❌ 404 when going to the page via the megamenu

CleanShot 2025-02-27 at 12 02 29

@amankumarrr
Copy link
Member Author

https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net/netug/sydney - ❌ 404 https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net/netug/canberra - ✅ https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net/netug/melbourne - ✅ https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net/netug/brisbane - ✅

can you retry that, it does work for me
image

@wicksipedia
Copy link
Member

https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net/netug

Sydney link 404s unless opened in a new window

CleanShot 2025-02-27 at 12 05 21

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 67
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 58
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@amankumarrr
Copy link
Member Author

https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net/netug

Sydney link 404s unless opened in a new window

CleanShot 2025-02-27 at 12 05 21

Issue doesn't seem to be persisted anymore after rebuilding the solution.

@amankumarrr amankumarrr enabled auto-merge (squash) February 27, 2025 03:44
auto-merge was automatically disabled February 27, 2025 03:48

Pull Request is not mergeable

@amankumarrr amankumarrr enabled auto-merge (squash) February 27, 2025 03:48
@amankumarrr amankumarrr disabled auto-merge February 27, 2025 03:51
@wicksipedia wicksipedia enabled auto-merge (squash) February 27, 2025 03:53
auto-merge was automatically disabled February 27, 2025 03:57

Pull Request is not mergeable

@amankumarrr amankumarrr enabled auto-merge (squash) February 27, 2025 03:58
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

@amankumarrr amankumarrr merged commit a708e20 into main Feb 27, 2025
15 of 16 checks passed
@amankumarrr amankumarrr deleted the 3167-app-routing-netug branch February 27, 2025 04:37
@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 70
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3647.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wicksipedia wicksipedia wicksipedia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ App Router migration - Netug
2 participants
@amankumarrr @wicksipedia