ci/unit-tests: add verbose mode with Ginkgo

[ldevulder]

Add verbose mode to have all messages in the unit-tests log, as some are not showned by default. Could be useful for debugging purposes.

[dirkmueller]

imho this is too verbose by default. how about we make it optional, triggerable via an extra V=1 parameter:

--- a/Makefile
+++ b/Makefile
@@ -12,17 +12,23 @@ LDFLAGS:=-w -s
 LDFLAGS+=-X "$(GO_MODULE)/internal/cli/cmd.version=$(GIT_TAG)"
 LDFLAGS+=-X "$(GO_MODULE)/internal/cli/cmd.gitCommit=$(GIT_COMMIT)"
 
+ifeq ($(V),1)
+  VERBOSE=-v
+else
+  VERBOSE=
+endif
+
 elemental:
        go build -ldflags '$(LDFLAGS)' -o $@ ./cmd/...
 
 .PHONY: unit-tests
 unit-tests:
-       go run $(GINKGO) --label-filter '!rootlesskit' --race --cover --coverpkg=github.com/suse/elemental/... --github-output -p -r ${PKG}
+       go run $(GINKGO) --label-filter '!rootlesskit' --race --cover --coverpkg=github.com/suse/elemental/... --github-output -p -r ${VERBOSE} ${PKG}
 ifeq (, $(shell which rootlesskit 2>/dev/null))
        @echo "No rootlesskit utility found, not executing tests requiring it"
 else
        @mv coverprofile.out coverprofile.out.bk
-       rootlesskit go run $(GINKGO) --label-filter 'rootlesskit' --race --cover --coverpkg=github.com/suse/elemental/... --github-output -p -r ${PKG}
+       rootlesskit go run $(GINKGO) --label-filter 'rootlesskit' --race --cover --coverpkg=github.com/suse/elemental/... --github-output -p -r ${VERBOSE} ${PKG}
        @grep -v "mode: atomic" coverprofile.out >> coverprofile.out.bk
        @mv coverprofile.out.bk coverprofile.out
 endif

[ldevulder]

imho this is too verbose by default. how about we make it optional, triggerable via an extra V=1 parameter:

We can yes for those who execute the unit-tests locally. I will just enable this for the CI, as I want to be able to have all logs for each merge (easier to analyse in case of issue). I will do a fix.

[fgiudici]

LGTM