Merge pull request #13 from sevaske/fix-pr-11

fix: Fixed the issue in the README.md + Fixed the directory creation logic in ensureDirectoryExists()

Author: Saleh7

README.md

@@ -321,7 +321,7 @@ $certificate = $json_data['certificate'];
 $secret = $json_data['secret'];
 
 // Load the private key
-$privateKey = (new Storage)->put(__DIR__ . '/output/private.pem');
+$privateKey = (new Storage)->get(__DIR__ . '/output/private.pem');
 $cleanPrivateKey = trim(str_replace(["-----BEGIN PRIVATE KEY-----", "-----END PRIVATE KEY-----"], "", $privateKey));
 
 // Create a Certificate instance
@@ -332,10 +332,9 @@ $certificate = new Certificate(
 );
 
 // Sign the invoice
-$signedInvoice = InvoiceSigner::signInvoice($xmlInvoice, $certificate);
-
+$signedInvoice = InvoiceSigner::signInvoice($xmlInvoice, $certificate)->getXML();
 // Save the signed invoice
-InvoiceSigner::signInvoice($xmlInvoice, $certificate)->saveXMLFile('/output/signed_invoice.xml');
+(new Storage)->put(__DIR__.'/output/signed_invoice.xml', $signedInvoice);
 ```
 
 ### 📤 **5. Submitting the Signed Invoice to ZATCA**  

examples/SigningInvoices.php

@@ -22,11 +22,11 @@
 // get private key
 $privateKey = file_get_contents(__DIR__ .'/output/private.pem');
 
-$claenPrivateKey = trim(str_replace(["-----BEGIN PRIVATE KEY-----", "-----END PRIVATE KEY-----"], "", $privateKey));
+$cleanPrivateKey = trim(str_replace(["-----BEGIN PRIVATE KEY-----", "-----END PRIVATE KEY-----"], "", $privateKey));
 
 $certificate = (new Certificate(
     $certificate,
-    $claenPrivateKey,
+    $cleanPrivateKey,
     $secret 
 )); 
 

src/Storage.php

@@ -147,18 +147,21 @@ protected function ensureDirectoryExists(string $path): void
         }
 
         // If directory exists but is not writable, throw exception
-        if (is_dir($path) && !is_writable($path)) {
-            throw new ZatcaStorageException('Directory exists but is not writable.', ['path' => $path]);
+        if (is_dir($path)) {
+            if (!is_writable($path)) {
+                throw new ZatcaStorageException('Directory exists but is not writable.', ['path' => $path]);
+            }
+            return;
         }
 
-        // If parent directory is not writable, fail before mkdir()
+        // Ensure the parent directory exists before creating the target directory
         $parentDir = dirname($path);
-        if (!is_writable($parentDir)) {
-            throw new ZatcaStorageException('Parent directory is not writable.', ['path' => $parentDir]);
+        if (!is_dir($parentDir)) {
+            $this->ensureDirectoryExists($parentDir); // Recursively create parent directories
         }
 
         // If directory does not exist, attempt to create it
-        if (!is_dir($path) && !mkdir($path, 0777, true) && !is_dir($path)) {
+        if (!is_dir($path) && !mkdir($path, 0755, true) && !is_dir($path)) {
             throw new ZatcaStorageException('Failed to create directory.', ['path' => $path]);
         }
     }