Skip to content

os/include: Remove conditional directives use from all enums. #6802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

kripal-samsung
Copy link
Contributor

Remove conditional directives use from all enums in os/include

@kripal-samsung kripal-samsung force-pushed the Remove_cond_Directives branch from ff4da1b to f4e9eb1 Compare April 25, 2025 07:33
@kripal-samsung kripal-samsung force-pushed the Remove_cond_Directives branch 2 times, most recently from 2809212 to 6f7b6ea Compare April 25, 2025 13:16
@kripal-samsung kripal-samsung force-pushed the Remove_cond_Directives branch from 6f7b6ea to 832805a Compare April 28, 2025 07:37
kishore-sn
kishore-sn previously approved these changes Apr 28, 2025
Copy link
Contributor

@Sambhavi-1 Sambhavi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional directive are removed from all enums looks good

Copy link
Contributor

@samsung-singh samsung-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed conditional directives use from all enums in os include this change is good to merge.

kishore-sn
kishore-sn previously approved these changes May 20, 2025
r-prabu
r-prabu previously approved these changes May 21, 2025
@kripal-samsung kripal-samsung dismissed stale reviews from r-prabu and kishore-sn via 9bd51d3 May 21, 2025 13:23
@kripal-samsung kripal-samsung force-pushed the Remove_cond_Directives branch 3 times, most recently from 479c9ed to 435ea84 Compare May 21, 2025 14:06
@kripal-samsung kripal-samsung force-pushed the Remove_cond_Directives branch from 435ea84 to 223f06b Compare May 22, 2025 08:40
@kripal-samsung kripal-samsung force-pushed the Remove_cond_Directives branch from 223f06b to ffdad5b Compare May 22, 2025 09:14
Remove conditional directives use from all enums in os/include
Remove conditional directives use from all enums in apps/system/utils
@kripal-samsung kripal-samsung force-pushed the Remove_cond_Directives branch from ffdad5b to 573a5b1 Compare May 22, 2025 10:33
@kishore-sn kishore-sn merged commit af27725 into Samsung:master May 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants