-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parametric equalizer and implement it for Arctis Nova 5 #393
base: master
Are you sure you want to change the base?
Conversation
c30d005
to
ce2a113
Compare
I undid the formatting changes of the lines the format-check job complained about. I don't understand why, though, since those changes were the result of running |
ce2a113
to
e537f2f
Compare
Thank you, very well done. (And sorry for the delay, winter flu got me for some time) There is a small crash when opening up the help with the test device:
|
Thanks and no worries. I hope you're better now :)
I fixed the crashing test device help. I initially just added the capability but forgot to create and attach the ParametricEqualizerInfo to the test device. |
Changes made
Added support for parametric equalizers.
Added implementation for Arctis Nova 5.
Description
I did not want to break the existing basic equalizer implementation so I added it independently as
I added YAML and JSON outputs, help texts, output of capabilities and the five filter types the Arctis Nova 5 supports for now.
More filter types can be added if other headsets feature different filters and the supported filters are set by each devices implementation.
I implemented the 10 band parametric equalizer for the Arctis Nova 5 and tested setting bands and the different filter types against the SteelSeries GG Windows software.
Bands are represented by the typical parameters of parametric equalizers: frequency, gain, q-factor (band width) and filter type.
This is the help text (which also gives an example of the format I chose to specify the bands):
This is the info the JSON (and YAML) output contains:
Headset Name
Arctis Nova 5
Checklist