Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Insights Inventory locators (foreman_rh_cloud #935) #1735

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Update Insights Inventory locators (foreman_rh_cloud #935) #1735

merged 1 commit into from
Feb 7, 2025
+4 −4

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Feb 7, 2025 •
edited
Loading

This PR updates the Insights Inventory views affected by the changes in theforeman/foreman_rh_cloud#935

@tpapaioa tpapaioa added No-CherryPick PR doesnt need CherryPick to previous branches Stream labels Feb 7, 2025
@tpapaioa tpapaioa requested a review from ColeHiggins2 February 7, 2025 14:52
@tpapaioa tpapaioa self-assigned this Feb 7, 2025
chris1984
chris1984 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 7, 2025
@tpapaioa tpapaioa removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 7, 2025
@tpapaioa tpapaioa force-pushed the update_insights_inventory_locators branch from 70fc983 to 88787cc Compare February 7, 2025 16:32
@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 10130
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_rhcloud_inventory.py::test_rhcloud_inventory_e2e[rhel8-ipv4] --external-logging
Test Result: ================== 1 passed, 12 warnings in 752.74s (0:12:32) ==================

@tpapaioa tpapaioa force-pushed the update_insights_inventory_locators branch from 88787cc to 9e19d3a Compare February 7, 2025 18:41
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Feb 7, 2025
@ColeHiggins2 ColeHiggins2 merged commit 6e73437 into SatelliteQE:master Feb 7, 2025
9 checks passed
@tpapaioa tpapaioa deleted the update_insights_inventory_locators branch February 7, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

Assignees

@tpapaioa tpapaioa

Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpapaioa @Satellite-QE @chris1984 @ColeHiggins2