-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zip_longest instead of zip in parse_csv #14109
Conversation
trigger: test-robottelo |
Does this work in the situations all of those linked PRs were trying to solve or does it just mask the problem? The reason I ask is because there is a difference in zipped iterables where data from one is lost by turning off strict mode. |
PRT Result
|
It does work in a sense that it unblocks tests. Without the need to work around the csv sniffing, we are left only with jobinvocation hammer output that does not fit. There is a bz for it, so maybe I can add some logic around that. |
So I made a change to zip_longest, so that data are kept in case of mismatch |
An observation from my investigation on #13989: |
closing in favor of #13989 |
Problem Statement
The Ruff code standard B905 requires the zip strict value to be explicitly stated, it does not require it to be True.
Solution
This PR sets the value to what it (implicitly) was before #13491 thus removing the need for #13737 #13797 #13999 #13989 and additional changes discussed in the last mentioned PR
[edit]: using zip_longest to not drop any data and adding log about the mismatch