Ensure correct finalizer order

[dosas]

Problem Statement

the host was not deleted before the hostgroup

see: pytest-dev/pytest#10023 (comment)

Solution

Execute host finalizer after hostgroup finalizer

Note

This should replace #14568

[Griffin-Sullivan]

Interesting how the finalizers work as a stack. My recommendation would be to flip the order of creation. Make the HG then the host and leave finalizers right after each create. Although this works too.

[dosas]

Interesting how the finalizers work as a stack. My recommendation would be to flip the order of creation. Make the HG then the host and leave finalizers right after each create. Although this works too.

My recommendation would be to flip the order of creation.

Wouldn't that change the test logic?

robottelo/tests/foreman/api/test_parameters.py

Lines 28 to 30 in cb296b3

	1. Create Global Parameter
	2. Create host and verify global parameter is assigned
	3. Create Host Group with parameter

[JacobCallahan]

I overall like this approach better than the fixture-heavy one. However, I will block on changing creation order (and yes the test logic order) to create the hostgroup first, then add its finalizer before creating the host. This is the best balance between ensuring finalizer execution order and actual execution if something goes wrong between entity creation and finalizer addition.

[Gauravtalreja1]

trigger: test-robottelo
pytest: tests/foreman/api/test_parameters.py

[Satellite-QE]

PRT Result

Build Number: 6453
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_parameters.py --external-logging
Test Result : ================== 1 passed, 9 warnings in 655.80s (0:10:55) ===================

[JacobCallahan]

ACK, thanks for taking this on!