Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] Move ansible API tests to Ansible-Cfgmgmt and REX classes #14637

Merged

Conversation

Gauravtalreja1
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 commented Apr 5, 2024

Manual cherrypick of #14626

@Gauravtalreja1 Gauravtalreja1 added API Issues and PRs involving the API No-CherryPick PR doesnt need CherryPick to previous branches Failed_AutoCherryPick Issue for failed/conflicted auto cherry pick of PRs 6.13.z Introduced in or relating directly to Satellite 6.13 labels Apr 5, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Apr 5, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6323
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_ansible.py --external-logging
Test Result : =========== 10 passed, 1165 warnings, 1 error in 5994.76s (1:39:54) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 5, 2024
@Gauravtalreja1
Copy link
Collaborator Author

PRT looks due to an intermittent issue, so I think this PR is ready for review/merge

@omkarkhatavkar
Copy link

we are seeing same error as here as well WARNING nailgun.client:client.py:126 Received HTTP 500 response: { "error": {"message":"PG::ForeignKeyViolation: ERROR: update or delete on table \"hosts\" violates foreign key constraint \"fact_values_host_id_fk\" on table \"fact_values\"\nDETAIL: Key (id)=(5) is still referenced from table \"fact_values\".\n"} } like this PR #14635 (comment)

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py::TestAnsibleCfgMgmt

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6443
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_ansible.py::TestAnsibleCfgMgmt --external-logging
Test Result : ================= 3 passed, 221 warnings in 1868.15s (0:31:08) =================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 11, 2024
…E#14626)

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit 4ad590a)
@Gauravtalreja1 Gauravtalreja1 force-pushed the move-ansible-rex-api-613z branch from de9010b to 2f4c23d Compare April 11, 2024 18:27
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 11, 2024
@Gauravtalreja1
Copy link
Collaborator Author

Gauravtalreja1 commented Apr 11, 2024

@omkarkhatavkar as I mentioned in earlier, it is intermittent issue, will investigate this later.

Just rebased, PRT is passed, we're good to merge it now?

@omkarkhatavkar
Copy link

I don't see this intermittent issue as this produced multiple times with the same error with different cherry pick branch versions as well.

Just looking at how you have run this test, earlier you tried running tests as a whole test module it failed every time. Where as later you run this as test class it starts passing. Which signifies that this could be due to the previous test causing the issue or something that modifies the setup. I will not hold your PR if you wanted to fix this later.

@omkarkhatavkar omkarkhatavkar merged commit 3cdef79 into SatelliteQE:6.13.z Apr 12, 2024
10 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the move-ansible-rex-api-613z branch April 12, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 API Issues and PRs involving the API Failed_AutoCherryPick Issue for failed/conflicted auto cherry pick of PRs No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed-AutoCherryPick] - Move ansible API tests to Ansible-Cfgmgmt and REX classes
3 participants