Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] Should not be able to publish the content-view, while repository sync in-progress #14677

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[RFE] Should not be able to publish the content-view, while repository sync in-progress #14677

merged 1 commit into from
Apr 11, 2024

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Apr 8, 2024 •
edited
Loading

Reason

API Automation coverage for [RFE] SAT-2927 and BZ# 1957144
Target Milestone is 6.15.0, no CP to 6.14.z

Steps

  • Add repository to content-view
  • Perform asynchronous repository sync
  • Attempt to publish a version of the content-view, while repo sync ongoing.
  • Assert: Raised HTTP exception, publish task failed, repo sync task_id found in humanized error, CV versions unchanged.

PRT Trigger

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync

@damoore044 damoore044 added RFE Issues that are requesting an enhancement to robottelo CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 8, 2024
@damoore044 damoore044 requested a review from a team April 8, 2024 16:40
@damoore044 damoore044 self-assigned this Apr 8, 2024
@damoore044 damoore044 requested a review from a team as a code owner April 8, 2024 16:40
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6364
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync --external-logging
Test Result : ================== 1 passed, 4 warnings in 773.40s (0:12:53) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024
@damoore044 damoore044 force-pushed the RFE_reposync_publish branch from d33051b to dac8623 Compare April 8, 2024 16:59
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync

2 similar comments
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync

@devendra104
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6370
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync --external-logging
Test Result : ================== 1 passed, 4 warnings in 755.51s (0:12:35) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024
vijaysawant
vijaysawant requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add test :steps: along with these 3 testimony tokens ?
:customerscenario:
:BZ:
:CaseAutomation:

vsedmik
vsedmik approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus one to add the steps, otherwise looks good.

@damoore044 damoore044 force-pushed the RFE_reposync_publish branch from dac8623 to ba9bc69 Compare April 10, 2024 15:57
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
@damoore044 damoore044 requested a review from vijaysawant April 10, 2024 18:56
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6433
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync --external-logging
Test Result : ================== 1 passed, 10 warnings in 663.91s (0:11:03) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
vijaysawant
vijaysawant approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 👍

Optional - @damoore044 Do you thing rest of 3 testimony tokens are also require to add?
:customerscenario:
:BZ:
:CaseAutomation:

@damoore044 damoore044 force-pushed the RFE_reposync_publish branch from ba9bc69 to c37616c Compare April 11, 2024 13:34
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 11, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6455
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_negative_publish_during_repo_sync --external-logging
Test Result : ================== 1 passed, 10 warnings in 708.89s (0:11:48) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 11, 2024
@damoore044 damoore044 force-pushed the RFE_reposync_publish branch from c37616c to 171b5ad Compare April 11, 2024 14:04
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 11, 2024
@damoore044 damoore044 force-pushed the RFE_reposync_publish branch from 171b5ad to b761f04 Compare April 11, 2024 14:19
@vijaysawant vijaysawant merged commit ac18e51 into SatelliteQE:master Apr 11, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@damoore044 @web-flow
[RFE] Should not be able to publish the content-view, while repositor…
14b5e4a 
…y sync in-progress (#14677)

[RFE] Should not be able to publish the content-view, while repository sync in-progress.

(cherry picked from commit ac18e51)
@Satellite-QE Satellite-QE mentioned this pull request Apr 11, 2024
Merged
@damoore044 damoore044 mentioned this pull request May 1, 2024
Closed
@damoore044 damoore044 mentioned this pull request May 8, 2024
Merged
@Satellite-QE Satellite-QE mentioned this pull request May 15, 2024
Closed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@damoore044 @jyejare
[RFE] Should not be able to publish the content-view, while repositor…
195c949 
…y sync in-progress (SatelliteQE#14677)

[RFE] Should not be able to publish the content-view, while repository sync in-progress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@vsedmik vsedmik vsedmik approved these changes

@sambible sambible Awaiting requested review from sambible

@LadislavVasina1 LadislavVasina1 Awaiting requested review from LadislavVasina1

Assignees

@damoore044 damoore044

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches RFE Issues that are requesting an enhancement to robottelo Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@damoore044 @Satellite-QE @devendra104 @ColeHiggins2 @vijaysawant @vsedmik