[6.14.z] Fix KA check

[vsedmik]

Problem Statement

KA removal warning test is failing since 6.15 scenario has been removed from foreman-maintain nightly.

Solution

Use 6.15 version of foreman-maintain instead.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/destructive/test_katello_agent.py -k test_positive_upgrade_warning

[vsedmik]

trigger: test-robottelo
pytest: tests/foreman/destructive/test_katello_agent.py -k test_positive_upgrade_warning

[Satellite-QE]

PRT Result

Build Number: 6494
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_katello_agent.py -k test_positive_upgrade_warning --external-logging
Test Result : ========== 1 passed, 20 deselected, 37 warnings in 2411.77s (0:40:11) ==========

[vsedmik]

trigger: test-robottelo
pytest: tests/foreman/destructive/test_katello_agent.py -k test_positive_upgrade_warning

[Satellite-QE]

PRT Result

Build Number: 6518
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_katello_agent.py -k test_positive_upgrade_warning --external-logging
Test Result : ========== 1 passed, 20 deselected, 37 warnings in 2310.19s (0:38:30) ==========

[jameerpathan111]

@vsedmik Do we need to keep this hardcoded? I don't understand the reason for removing the original code related to target_ver. Or we can use SATELLITE_VERSION that would be better in my opinion than having another constant here. wdyt?

from robottelo.constants import SATELLITE_VERSION
target_ver  = float(SATELLITE_VERSION) + 1

[vsedmik]

@jameerpathan111 The idea behind is that this test is "6.14.z-only" so the next version is always 6.15. But I don't mind to bring the original code back if you think it's better.

[jameerpathan111]

Yeah, but it's always good to keep things consistent across the branches, it avoids complications going forward like in the case of cherry picks. Anyway, you have my ACK:)

[vsedmik]

This test cannot pass in branches other than 6.14.z so I wouldn't be afraid of CPs. Anyway, updated for consistency.

[vsedmik]

trigger: test-robottelo
pytest: tests/foreman/destructive/test_katello_agent.py -k test_positive_upgrade_warning

[Satellite-QE]

PRT Result

Build Number: 6552
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_katello_agent.py -k test_positive_upgrade_warning --external-logging
Test Result : ========== 1 passed, 20 deselected, 37 warnings in 2463.58s (0:41:03) ==========