Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAT-30611] Test Applied Errata report by hostname #17702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Feb 27, 2025

Problem Statement

test_positive_applied_errata_for_specific_hosts covers SAT-30611 for report filtered by hostname,
but also reported was a perceived discrepancy with the date fields, I found we don't yet test the dates for the Hosts - Applied Errata ReportTemplate.

  • New coverage (nice-to-have) test_positive_applied_errata_by_install_date
    now tests the 'Since' and 'Up to' date fields.
  • ^ PRT is failing for this _install_date case in 6.17.z and Stream, will remove that and open in a separate PR so we can merge this bug's coverage. [Robottelo Applied Errata Report by Install Dates: 'Since' and 'Up to' #17713 ]

PRT

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py -k '_specific_hosts'

@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z labels Feb 27, 2025
@damoore044 damoore044 self-assigned this Feb 27, 2025
@damoore044 damoore044 force-pushed the app_errata_report branch 3 times, most recently from f164549 to 06aa920 Compare February 27, 2025 00:56
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py::test_positive_applied_errata_for_specific_hosts tests/foreman/api/test_reporttemplates.py::test_positive_applied_errata_by_install_date

@damoore044 damoore044 force-pushed the app_errata_report branch 3 times, most recently from e99cd9b to 802109c Compare February 27, 2025 14:18
Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording nit, but tests LGTM! nice job :)

:id: 57025661-37cb-44bd-917a-a173605926ad

:setup:
1. Two registered hosts with an outdated applicable package installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Two registered hosts with an outdated applicable package installed.
1. Two registered hosts, each with a different applicable erratum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is more clear, will push this next

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py -k '_specific_hosts or _install_date'

@damoore044 damoore044 added the QETestCoverage Issues and PRs relating to a Satellite bug label Feb 27, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10342
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_reporttemplates.py -k _specific_hosts or _install_date --external-logging
Test Result : ==== 3 failed, 3 passed, 42 deselected, 838 warnings in 2889.51s (0:48:09) =====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 27, 2025
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py::test_positive_applied_errata_by_install_date

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10346
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_reporttemplates.py::test_positive_applied_errata_by_install_date --external-logging
Test Result : ================= 3 failed, 278 warnings in 1759.86s (0:29:19) =================

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10349
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_reporttemplates.py::test_positive_applied_errata_by_install_date --external-logging
Test Result : ================= 3 failed, 290 warnings in 1682.31s (0:28:02) =================

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10350
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_reporttemplates.py::test_positive_applied_errata_by_install_date --external-logging
Test Result : ================= 3 failed, 290 warnings in 1752.04s (0:29:12) =================

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py -k '_specific_hosts'

@damoore044 damoore044 changed the title [SAT-30611] Test Applied Errata report by hostname and date [SAT-30611] Test Applied Errata report by hostname Feb 28, 2025
@damoore044 damoore044 marked this pull request as ready for review February 28, 2025 14:58
@damoore044 damoore044 requested a review from a team as a code owner February 28, 2025 14:58
@damoore044 damoore044 added the 6.15.z Introduced in or relating directly to Satellite 6.15 label Feb 28, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10355
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_reporttemplates.py -k _specific_hosts --external-logging
Test Result : ========= 3 passed, 42 deselected, 675 warnings in 2789.95s (0:46:29) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants