Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-exports common libs
bitcoin
,elements
andlightning_invoice
.TLDR: This allows callers, if necessary, to use structs from these libs without having to worry about having an incompatible lib version.
For example, without this PR, a caller would have access to
lightning_invoice::Bolt11Invoice
asboltz_client::Bolt11Invoice
, but not tolightning_invoice::Bolt11InvoiceDescription
since this is not re-exported at the moment. If the caller would import thelightning_invoice
dependency to get access to this, they may run into compatibility issues if they use e.g.Bolt11Invoice::from_str(..)?.description()
with the import fromboltz_client
andBolt11InvoiceDescription
from their own dependency.With the new re-exports, callers can access all structs from
boltz_client
's specific versions ofbitcoin
,elements
andlightning_invoice
.