refactor: use SurrogatesBase for all surrogates #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathvikbhagavan
changed the title
src/
sathvikbhagavan
force-pushed
the
sb/refactor
branch
from
2d0ad8d to
c04adbd
Compare
sathvikbhagavan
force-pushed
the
sb/refactor
branch
from
6a1a7c1 to
d296c35
Compare
|
@ChrisRackauckas, I have updated all surrogates to use SurrogatesBase now. Tests for SurrogatesAbstractGPs are failing because of compat issues of KernelFunctions.jl - needs JuliaGaussianProcesses/KernelFunctions.jl#562 I will clean up the docs in a different PR |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.