Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swift-nightly #1620

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Add swift-nightly #1620

merged 2 commits into from
Mar 20, 2024

Conversation

deevus
Copy link
Member

@deevus deevus commented Mar 3, 2024

This adds a nightly version for Swift

I copied the manifest from the main bucket and updated it to get the nightly version from the official download page.

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Your changes do not pass checks.

swift5.10-nightly

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@deevus
Copy link
Member Author

deevus commented Mar 3, 2024

This is not quite working. It seems as though the archive used for the development snapshots are not the same as release.

scoop install .\bucket\swift5.10-nightly.json
WARN  Purging previous failed installation of swift5.10-nightly.
ERROR 'swift5.10-nightly' isn't installed correctly.
Removing older version (5.10-DEVELOPMENT-SNAPSHOT-2024-02-27).
'swift5.10-nightly' was uninstalled.
Installing 'swift5.10-nightly' (5.10-DEVELOPMENT-SNAPSHOT-2024-02-27) [64bit] from 'C:\Users\Simon\Projects\ScoopVersions\bucket\swift5.10-nightly.json'
Loading swift-5.10-DEVELOPMENT-SNAPSHOT-2024-02-27-a-windows10.exe from cache.
Checking hash of swift-5.10-DEVELOPMENT-SNAPSHOT-2024-02-27-a-windows10.exe ... ok.
Running pre_install script...
ERROR Exit code was 1620!
Failed to extract files from C:\Users\Simon\scoop\apps\swift5.10-nightly\5.10-DEVELOPMENT-SNAPSHOT-2024-02-27\extract_folder\AttachedContainer\a0.
Log file:
  ~\scoop\apps\swift5.10-nightly\5.10-DEVELOPMENT-SNAPSHOT-2024-02-27\extract_folder\AttachedContainer\msi.log

The mentioned log file is empty.

@FlawlessCasual17 Pinging you since you created the original Swift manifest and have been submitting updates for it

@deevus deevus added blocked Blocked by another PR or issue bug and removed blocked Blocked by another PR or issue labels Mar 3, 2024
@deevus deevus changed the title Add swift-5.10-nightly Add swift-nightly Mar 20, 2024
@deevus
Copy link
Member Author

deevus commented Mar 20, 2024

/verify

@deevus deevus marked this pull request as ready for review March 20, 2024 06:59
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

swift-nightly

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@deevus deevus requested a review from tech189 March 20, 2024 06:59
@deevus
Copy link
Member Author

deevus commented Mar 20, 2024

This is using nightly builds from The Browser Company, since they are currently not offered officially by Apple

@deevus deevus merged commit b0f18f2 into ScoopInstaller:master Mar 20, 2024
2 checks passed
@deevus deevus deleted the swift-5.10-nightly branch March 20, 2024 09:22
"env_add_path": [
"Runtimes\\usr\\bin",
"Toolchains\\usr\\bin",
"Tools"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to leave Tools in the path if it doesn't exist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it works fine. Might be worth deleting though

@FlawlessCasual17
Copy link
Contributor

FlawlessCasual17 commented Mar 27, 2024

@deevus
Hey, do you guys still need help, sorry for not responding. I was busy with IRL stuff, like university.

@deevus
Copy link
Member Author

deevus commented Mar 27, 2024

@deevus Hey, do you guys still need help, sorry for not responding. I was busy with IRL stuff, like university.

No problem. All good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants