Continued Pest mutation testing (#79)

* Add mutation test coverage for `AccountController`

* Add mutation test coverage for `DashboardController`

* Add mutation test coverage for `LogoutController`

* Add missing bits

* Update composer.json

* Update ResetPasswordControllerTest.php

* Update EmailVerificationControllerTest.php

* Update Pest to v3.1.0

* Replace `covers()` with `mutates()`

* Update composer.json

Author: SebKay

app/Http/Controllers/LoginController.php

@@ -27,6 +27,8 @@ public function store(LoginStoreRequest $request)
             ])
         );
 
+        session()->regenerate();
+
         if ($request->validated('redirect')) {
             return redirect()->to($request->validated('redirect'));
         }

app/Http/Controllers/LogoutController.php

@@ -10,8 +10,8 @@ public function __invoke(Request $request)
     {
         auth()->guard()->logout();
 
-        $request->session()->invalidate();
-        $request->session()->regenerateToken();
+        session()->regenerateToken();
+        session()->invalidate();
 
         return redirect()->route('login');
     }

app/Http/Controllers/ResetPasswordController.php

@@ -26,6 +26,8 @@ public function store(ResetPasswordStoreRequest $request)
             'reset_link' => __($status),
         ]));
 
+        session()->regenerate();
+
         session()->flash('success', __('passwords.sent'));
 
         return redirect()->route('login');

composer.json

@@ -68,6 +68,9 @@
         "test:coverage": [
             "XDEBUG_MODE=coverage ./vendor/bin/pest --parallel --stop-on-failure --coverage --min=85"
         ],
+        "test:mutations": [
+            "XDEBUG_MODE=coverage ./vendor/bin/pest --mutate"
+        ],
         "artisan:build": [
             "@php artisan horizon:terminate",
             "@php artisan cache:clear",

composer.lock

@@ -9,6 +9,8 @@
 use function Pest\Laravel\get;
 use function Pest\Laravel\patch;
 
+mutates(\App\Http\Controllers\AccountController::class);
+
 describe('Users', function () {
     test('Can access the edit page', function () {
         $user = User::factory()->create();

tests/Feature/Controllers/AccountControllerTest.php

@@ -6,6 +6,8 @@
 use function Pest\Laravel\actingAs;
 use function Pest\Laravel\get;
 
+mutates(\App\Http\Controllers\DashboardController::class);
+
 describe('Users', function () {
     test('Can access the home page', function () {
         actingAs(User::factory()->create())

tests/Feature/Controllers/HomeControllerTest.php renamed to tests/Feature/Controllers/DashboardControllerTest.php

@@ -7,6 +7,8 @@
 use function Pest\Laravel\actingAs;
 use function Pest\Laravel\get;
 
+mutates(\App\Http\Controllers\EmailVerificationController::class);
+
 describe('Users', function () {
     test('Can access the verification page', function () {
         actingAs(User::factory()->unverified()->create())

tests/Feature/Controllers/EmailVerificationControllerTest.php

@@ -11,6 +11,8 @@
 use function Pest\Laravel\get;
 use function Pest\Laravel\post;
 
+mutates(App\Http\Controllers\LoginController::class);
+
 describe('Users', function () {
     test("Can't access the login page", function () {
         actingAs(User::factory()->create())

tests/Feature/Controllers/LoginControllerTest.php

@@ -3,21 +3,28 @@
 use App\Models\User;
 
 use function Pest\Laravel\actingAs;
-use function Pest\Laravel\assertAuthenticated;
 use function Pest\Laravel\assertGuest;
 use function Pest\Laravel\post;
 
+mutates(\App\Http\Controllers\LogoutController::class);
+
 describe('Users', function () {
     test('Can logout', function () {
+        session()->regenerateToken();
+
         actingAs(User::factory()->create());
 
-        assertAuthenticated();
+        $token = session()->token();
+        session()->put('test', 'data');
 
         post(route('logout'))
             ->assertSessionDoesntHaveErrors()
             ->assertRedirectToRoute('login');
 
         assertGuest();
+
+        expect(session()->token())->not->toEqual($token);
+        expect(session()->get('test'))->toBeNull();
     });
 });
 

tests/Feature/Controllers/LogoutControllerTest.php

@@ -12,6 +12,8 @@
 use function Pest\Laravel\get;
 use function Pest\Laravel\post;
 
+mutates(App\Http\Controllers\RegisterController::class);
+
 describe('Users', function () {
     test("Can't access the register page", function () {
         actingAs(User::factory()->create())

tests/Feature/Controllers/RegisterControllerTest.php

@@ -11,6 +11,8 @@
 use function Pest\Laravel\get;
 use function Pest\Laravel\patch;
 
+mutates(\App\Http\Controllers\ResetPasswordController::class);
+
 test('The forgot password page can be accessed', function () {
     get(route('password'))
         ->assertOk()