Skip to content

Commit 5648285

Browse files
authored
Fix add-cert-helper.sh only adding a single certificate in Chrome (#2660)
1 parent e342765 commit 5648285

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

charts/selenium-grid/certs/add-cert-helper.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ TARGET_CERT_DIR=${TARGET_CERT_DIR:-"/usr/local/share/ca-certificates"} # Target
5858
BUNDLE_CA_CERTS=${BUNDLE_CA_CERTS:-"/etc/ssl/certs/ca-certificates.crt"} # Bundle CA certificates
5959
NSSDB_HOME=${NSSDB_HOME:-"${HOME}/.pki/nssdb"} # Default location of the NSSDB
6060
APPEND_CRT_KEY="/tmp/tls.crt"
61-
ALIAS=${ALIAS:-"SeleniumHQ"}
61+
ALIAS_PREFIX=${ALIAS_PREFIX:-"SeleniumHQ"}
6262

6363
sudo mkdir -p ${TARGET_CERT_DIR}
6464

@@ -75,6 +75,7 @@ for cert_file in "${cert_files[@]}"; do
7575
else
7676
echo "Processing $cert_file"
7777
fi
78+
ALIAS="${ALIAS_PREFIX}_$(basename $cert_file)"
7879
cert_file=$(append_private_key_if_exists $cert_file)
7980
for cert_db_file in "${cert_db_files[@]}"; do
8081
echo "Adding to db: $cert_db_file"

tests/customCACert/bootstrap.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ docker build ${COMMON_BUILD_ARGS} --build-arg BASE=node-edge -t ${NAMESPACE}/nod
2222

2323
list_cert_files=($(find ./charts/selenium-grid/certs/ -name "*.crt"))
2424
for cert_file_path in "${list_cert_files[@]}"; do
25-
cert_nick_name="SeleniumHQ"
25+
cert_nick_name="SeleniumHQ_$(basename $cert_file_path)"
2626
docker run --entrypoint="" --rm ${NAMESPACE}/node-chrome:${VERSION} bash -c "certutil -L -d sql:/home/seluser/.pki/nssdb -n ${cert_nick_name}"
2727
docker run --entrypoint="" --rm ${NAMESPACE}/node-firefox:${VERSION} bash -c "certutil -L -d sql:/home/seluser/.pki/nssdb -n ${cert_nick_name}"
2828
docker run --entrypoint="" --rm ${NAMESPACE}/node-edge:${VERSION} bash -c "certutil -L -d sql:/home/seluser/.pki/nssdb -n ${cert_nick_name}"

0 commit comments

Comments
 (0)