Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feel free to open a PR on the original repo #3

Open
cmseaton42 opened this issue Mar 22, 2021 · 4 comments
Open

Feel free to open a PR on the original repo #3

cmseaton42 opened this issue Mar 22, 2021 · 4 comments

Comments

@cmseaton42
Copy link

Quick Question

Do you want to pull your changes to the original repository? Feel free to open a PR if you like. I can make you a maintainer so you pull your own PRs as I rarely have the time to look through code reviews these days.

Also, I am in the middle of a typescript rewrite of the repository that is much more stable (currently 100% coverage). Feel free to check that guy out as well if you like. The long term plan (assuming I ever get the time) is to fully transition to typescript.

@r4nd0wn
Copy link
Contributor

r4nd0wn commented Jan 31, 2022

I dont know whats going on with the maintainers. No responds to any request. I have a pull request open which never has been answered. Due to the Licence, feel free to merge it back to your repo :D

@SerafinTech
Copy link
Owner

Sorry for delay. I'll review tonight.

@r4nd0wn
Copy link
Contributor

r4nd0wn commented Feb 5, 2022

Any news on that?

@balbatross
Copy link

@cmseaton42 @SerafinTech As another maintainer of a node-ethernet-ip fork (https://github.com/TheTechCompany/node-ethernet-ip) it'd be great to collaborate on a shared repo. I'll be supporting my fork for the next 10-15 years out of necessity so it'd be great to share the work with the community and get to the bottom of this lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants