You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the bug find. I’ll be back to working on this repository after Jan 6, 2025On Dec 16, 2024, at 9:08 AM, cernym85 ***@***.***> wrote:
I found out that it's impossible to write negative value into DINT array, when writing whole array.
Current Behavior
Write fails on range check.
Possible Solution
Assuming that in function generateWriteMessageRequestForAtomic in /src/tag/index.ts on line 714 should be
valBuf.writeInt32LE(value[i], i * 4);
instead of
valBuf.writeUInt32LE(value[i], i * 4);
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
I found out that it's impossible to write negative value into DINT array, when writing whole array.
Current Behavior
Write fails on range check.
Possible Solution
Assuming that in function generateWriteMessageRequestForAtomic in /src/tag/index.ts on line 714 should be
valBuf.writeInt32LE(value[i], i * 4);
instead of
valBuf.writeUInt32LE(value[i], i * 4);
The text was updated successfully, but these errors were encountered: