From ae1dc96d8d3519aa90b5f60b46d8ffbfa7484422 Mon Sep 17 00:00:00 2001 From: optimass Date: Tue, 14 Jan 2025 23:41:20 +0000 Subject: [PATCH 1/3] cleaner --- src/browsergym/workarena/instance.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browsergym/workarena/instance.py b/src/browsergym/workarena/instance.py index 7614646..74749e7 100644 --- a/src/browsergym/workarena/instance.py +++ b/src/browsergym/workarena/instance.py @@ -143,7 +143,7 @@ def check_is_installed(self): """ property_name = "workarena.installation.date" try: - property_value = self._get_sys_property(property_name) + self._get_sys_property(property_name) except Exception as e: raise RuntimeError( f"ServiceNow instance is not installed." From f9f9c5c4401046c8032d7ffd1f1ffab7aac65bc7 Mon Sep 17 00:00:00 2001 From: optimass Date: Wed, 15 Jan 2025 18:40:56 +0000 Subject: [PATCH 2/3] fixes --- src/browsergym/workarena/install.py | 4 ++-- src/browsergym/workarena/instance.py | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/browsergym/workarena/install.py b/src/browsergym/workarena/install.py index f9d0825..cbd8e5f 100644 --- a/src/browsergym/workarena/install.py +++ b/src/browsergym/workarena/install.py @@ -600,7 +600,7 @@ def setup_list_columns(): logging.info("... Creating a new user account to validate list columns") admin_instance = SNowInstance(check_installed=False) username, password, usysid = create_user(instance=admin_instance) - user_instance = SNowInstance(snow_credentials=(username, password)) + user_instance = SNowInstance(check_installed=False, snow_credentials=(username, password)) for task, task_info in list_mappings.items(): expected_columns_path = task_info["expected_columns_path"] @@ -706,7 +706,7 @@ def setup_form_fields(): logging.info("... Creating a new user account to validate form fields") admin_instance = SNowInstance(check_installed=False) username, password, usysid = create_user(instance=admin_instance) - user_instance = SNowInstance(snow_credentials=(username, password)) + user_instance = SNowInstance(check_installed=False, snow_credentials=(username, password)) for task, task_info in task_mapping.items(): expected_fields_path = task_info["expected_fields_path"] diff --git a/src/browsergym/workarena/instance.py b/src/browsergym/workarena/instance.py index 74749e7..bf43914 100644 --- a/src/browsergym/workarena/instance.py +++ b/src/browsergym/workarena/instance.py @@ -144,11 +144,10 @@ def check_is_installed(self): property_name = "workarena.installation.date" try: self._get_sys_property(property_name) - except Exception as e: + except Exception: raise RuntimeError( - f"ServiceNow instance is not installed." + f"ServiceNow instance is most likey not installed. " "Please install the WorkArena plugin by running `workarena-install`.\n" - "Error: {e}" ) def check_status(self): From 62dbadf7ea23cd0b5653d56e8ea50274360a6b18 Mon Sep 17 00:00:00 2001 From: optimass Date: Thu, 16 Jan 2025 19:04:42 +0000 Subject: [PATCH 3/3] fix --- src/browsergym/workarena/instance.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/browsergym/workarena/instance.py b/src/browsergym/workarena/instance.py index bf43914..c635eaa 100644 --- a/src/browsergym/workarena/instance.py +++ b/src/browsergym/workarena/instance.py @@ -148,6 +148,7 @@ def check_is_installed(self): raise RuntimeError( f"ServiceNow instance is most likey not installed. " "Please install the WorkArena plugin by running `workarena-install`.\n" + "Alternatively, your credentials might not be correct. Please check them." ) def check_status(self):