Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong stock check #22

Open
Roshyo opened this issue Jan 18, 2021 · 0 comments
Open

Wrong stock check #22

Roshyo opened this issue Jan 18, 2021 · 0 comments

Comments

@Roshyo
Copy link
Contributor

Roshyo commented Jan 18, 2021

In multiple places, there is this condition :

if ($child->getOnHand() > 0) {

and also

// Selected option needs to be in stock
            $optionBoolQuery->addMust(new Range('options.onHand', [
                'gt' => 0,
            ]));

but that wrongly assume that all products have a tracked stock. We should change that accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant