DO NOT MERGE: Image collage mashup #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevanmoothien
suggested changes
Aug 17, 2017
src/classes/SharinPixCollageDemo.cls
Outdated
| public static String albumId {get; set;} | ||
|
|
||
| static { | ||
| albumId = 'c74c803b-62a6-4b41-b7d8-7e7e14503dae'; |
There was a problem hiding this comment.
remplace cela par un nom d'album. (ex: demo-album)
src/package.xml
Outdated
| <members>SharinPixCollageDemo</members> | ||
| <name>ApexClass</name> | ||
| </types> | ||
| <version>36.0</version> |
| @@ -0,0 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <ApexClass xmlns="http://soap.sforce.com/2006/04/metadata"> | |||
| <apiVersion>36.0</apiVersion> | |||
src/pages/SharinPixCollageDemo.page
Outdated
| ); | ||
| } | ||
| </script> | ||
| <div style="padding: 10px 20px"> |
There was a problem hiding this comment.
utilise des classes plutot que du style en inline.
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <ApexPage xmlns="http://soap.sforce.com/2006/04/metadata"> | |||
| <apiVersion>36.0</apiVersion> | |||
src/pages/SharinPixCollageDemo.page
Outdated
| <apex:canvasApp developerName="Albums" height="500px" width="100%" parameters="{! parameters }" /> | ||
| </div> | ||
| <div style="padding: 10px 20px"> | ||
| <apex:form onsubmit="return false" id="main_form"> |
There was a problem hiding this comment.
tu peux ne pas mettre le form si tu ne fais pas de bind sur le controleur.
src/pages/SharinPixCollageDemo.page
Outdated
| window.location.hash = 'image_start'; | ||
| document.getElementById('image_start').style.visibility = 'visible' | ||
| }); | ||
| }, 10) |
src/pages/SharinPixCollageDemo.page
Outdated
| @@ -0,0 +1,58 @@ | |||
| <apex:page controller="SharinPixCollageDemo"> | |||
| <script> | |||
| let buttonClicked = function() { | |||
There was a problem hiding this comment.
utilise plutot var ici. C'est pus comprehensible pour la majorité des gens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.