Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable print button #25

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Enable print button #25

merged 1 commit into from
Nov 28, 2024

Conversation

atishdhu
Copy link
Collaborator

@atishdhu atishdhu commented Nov 20, 2024 •
edited
Loading

  • We need to add an event listener which enables the print button in horizontal toolbar and in the right submenu.
  • This event will be sent from core.

@atishdhu atishdhu self-assigned this Nov 20, 2024
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241120102434-cf3220481/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241120102807-88bcdf7d1/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241120103112-514c96b22/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241121132416-500183765/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122063023-a68d0c301/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122074721-774df831a/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122075240-a0a86a23a/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@atishdhu atishdhu force-pushed the enable-print-pdfjs branch 2 times, most recently from e947516 to f5658c9 Compare November 22, 2024 07:55
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122075537-0637df4f5/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122075657-7208d9dd7/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122084305-87226b0b7/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122095734-649be6350/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122113227-a2b840b12/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241122152739-ff5eafba6/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

keshav1720
keshav1720 approved these changes Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128112013-dbdbabdab/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128112432-d9faf0456/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128112639-a384def3f/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128113029-b68ebcc23/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128122845-b642ba3c6/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128123321-90c8fdab7/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128140040-afcc65da8/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128140317-cc37e8d96/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128142405-05ae99287/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

https://pdfjs-sp-fork.s3.us-east-1.amazonaws.com/pdfjs/20241128160947-555c73e87/web/viewer.html?file=https%3A%2F%2Fpdfjs-sp-fork.s3.us-east-1.amazonaws.com%2Fsample.pdf

@atishdhu atishdhu merged commit 1f76a9f into master Nov 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ombr ombr ombr approved these changes

@zfir zfir zfir approved these changes

@keshav1720 keshav1720 keshav1720 approved these changes

@azharbeebeejaun azharbeebeejaun Awaiting requested review from azharbeebeejaun

@DJoyekurun DJoyekurun Awaiting requested review from DJoyekurun

@chatquill chatquill Awaiting requested review from chatquill

@ashishven ashishven Awaiting requested review from ashishven

Assignees

@atishdhu atishdhu

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atishdhu @ombr @zfir @keshav1720