Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages with country codes not working #1173

Closed
tamodolo opened this issue Aug 30, 2024 · 8 comments
Closed

Languages with country codes not working #1173

tamodolo opened this issue Aug 30, 2024 · 8 comments

Comments

@tamodolo
Copy link

This is an issue for a reported problem on discord support channel related to languages with country codes like pt-br being ignored.

As TMDB is the largest database in pt-br I found this bug because the language wasn't being shown in webui. Here is some prints:

image
image
image

Also imagens shared by re: vam at the time:

image
image

VERSION INFORMATION

Server Version: 4.2.2.67

@ElementalCrisis
Copy link
Member

First screenshot shows you have EN higher than PT-BR for episode descriptions.

Fix this and refresh TMDB data.

@tamodolo
Copy link
Author

tamodolo commented Aug 30, 2024

First screenshot shows you have EN higher than PT-BR for episode descriptions.

Fix this and refresh TMDB data.

The image is wrong actually. It doen't work even after changing that. I'll glady provide extra info if needed. This issue was opened after talking with @revam about it on discord. The last 2 screen was his.

@harshithmohan
Copy link
Member

First screenshot shows you have EN higher than PT-BR for episode descriptions.

Fix this and refresh TMDB data.

The problem is with titles. We have PT-BR (which is equivalent to "BrazilianPortuguese" in the code) in shoko but TMDB data has the language as Portuguese and the country code as "BR" in two separate.
The titles are not added because "BrazilianPortuguese" != "Portuguese". The code doesn't check for the country code... yet

@tamodolo
Copy link
Author

I know that Shoko has some important features in the making and this is considered minor for non afected languages. For me that know english this is not a problem too but it is for my child niece that don't know english (yet). For her this issue is a major one. If this is not asking too much please give some atention to this issue. Thank you very much for this great software!

@da3dsoul
Copy link
Member

I know someone was working on this. I'm not sure if it was fixed. @revam can you comment?

@revam
Copy link
Member

revam commented Sep 28, 2024

Impo then the language support in Shoko needs to be overhauled to have more "proper" support for language & countey codes, but in the short-term i can throw in a few permanent temporary measures to fix it for 'pt-br' and any other language code (e.g. 'pt') + countey code (e.g. 'br') combinations we have mapped to title languages in our current system.

I'll see if I can get those measures in this weekend before I forget again.

@tamodolo
Copy link
Author

Impo then the language support in Shoko needs to be overhauled to have more "proper" support for language & countey codes, but in the short-term i can throw in a few permanent temporary measures to fix it for 'pt-br' and any other language code (e.g. 'pt') + countey code (e.g. 'br') combinations we have mapped to title languages in our current system.

I'll see if I can get those measures in this weekend before I forget again.

Real thank you all! I can see my niece already vibrating hahaha!

@revam revam closed this as completed in c313c85 Sep 29, 2024
@tamodolo
Copy link
Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants