Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry information missing #1233

Closed
Draic opened this issue Mar 18, 2025 · 8 comments
Closed

telemetry information missing #1233

Draic opened this issue Mar 18, 2025 · 8 comments

Comments

@Draic
Copy link

Draic commented Mar 18, 2025

during setup there is one page notifying about telemetry collection. I can not find any settings or information page about WHAT data is being collected and no choice in disabling it is given. Transparency and choice are important.

@Cazzar
Copy link
Member

Cazzar commented Mar 18, 2025

As it is mentioned in the disclaimer the specific details collected are around errors and some of the state around the error, similar to what gets shown in the error log

As a thing for some full transparency, an error in sentry that we see are the following:

Image

We also go out of our way to try and only gather any errors that would be exceptions in code that could cause UX issues. As well as going out of the way to explicitly remove any PII via Sentry's own PII Scrubbers and our own additional scrubbers.

There is also the ability to opt out in the server-settings.json if required, it does require a restart of the server.

@Draic
Copy link
Author

Draic commented Mar 18, 2025

please add opt out option to docker compose and the general information to the documentation. Not giving any information is why people distrust the practice and will not use the service at all.

Edit: hiding the opt out in a config file instead of giving people the choice during setup is also wrong

@Cazzar
Copy link
Member

Cazzar commented Mar 18, 2025

Unfortunately the way the configuration system works, we don't have an easy way of changing the configuration like that via docker compose at all, it has been something I've wanted to investigate for better setup support, though it has not been high on the priority list.

As for the documentation side of things, @ElementalCrisis - do you think that we could expand on it a little more on the docs so users can be more aware. & possibly make it a little clearer on opt out

@da3dsoul
Copy link
Member

You're running our code on your data with logins to your accounts without looking through every line of it on GitHub. Even if we were to spend time explaining things like this in painfully verbose detail, there will always be people that care too much. We have better things to focus on. Choose to trust us or not. It's your decision. We understand that our community in particular is full of people that blanket block analytics, and that's fine. These tools help users at the end of the day. We don't care if any particular edge case that only a single person has reported is fixed, but we can't fix it or even know if it's more common than we thought without data. We work on these things for free out of our own enjoyment.

Thank you for being polite. We will maybe, dare I say even probably, look at our documentation and see if we think it is clear enough.

@da3dsoul
Copy link
Member

da3dsoul commented Mar 18, 2025

The errors that might contain something that someone might consider private information are ones that are related to file paths, such as MediaInfo failing to read or sometimes renamer errors that are actually our fault. I don't consider that private in most cases, because docker usually abstracts most of it, but Windows installs have more access.

In this case, I think someone deleted a watched import folder while Shoko was running. We might be able to fix that? It would take investigation.
Image

@Draic
Copy link
Author

Draic commented Mar 18, 2025

Just be transparent. Seeding distrust by hiding information just because you think it is too detailed just gives people more reason to not bother with shoko or disable telemetry because they feel being mislead. Thats how I feel about it in fact. Going through installation and having no information about what is being collected and no way to disable it presented just had me remove it immediately :) treat users fairly by giving them the choice and information please.

@bigretromike
Copy link
Contributor

Just be transparent. Seeding distrust by hiding information just because you think it is too detailed just gives people more reason to not bother with shoko or disable telemetry because they feel being mislead. Thats how I feel about it in fact. Going through installation and having no information about what is being collected and no way to disable it presented just had me remove it immediately :) treat users fairly by giving them the choice and information please.

there used to be opt-out, then it was hidden inside config file to be later removed.

@da3dsoul there are many kind of personal data like preference (name of files that throw error), time of usage etc.
If you can correlate data easy enough to assign it to a user then its personal information ( a NAS named "da3dsolu" and file named "kinky-donky-hentai.avi" - no one want to share his pony fantasies, even worst would be setting import folder on ex. Documents).
Easy way would be replace everything except extension with asterisk (user data).

what would happened if you replace endpoint ip with something like 127.0.0.1 or wrong IP ? would it stop working or overrun system?

@ShokoAnime ShokoAnime locked as resolved and limited conversation to collaborators Mar 26, 2025
@Cazzar
Copy link
Member

Cazzar commented Mar 26, 2025

locking for now, as we don't need any more discourse around it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants