Made changes to the Navbar. #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edidiesky is attempting to deploy a commit to the poulavbhowmick03's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@edidiesky Can you give me a recording of the change? the UI in my device looks distorted for some reason |
PoulavBhowmick03
requested changes
Jan 25, 2025
client/components/landing/Navbar.tsx
Outdated
| <MenuItem href="/" isActive={active === "home"}>Home</MenuItem> | ||
| {/* Add more menu items here */} | ||
| </div> | ||
| <div className="w-full px-6 md:w-[90%] max-w-[1000px] mx-auto border border-[rgba(255,255,255,.2)] rounded-full bg-gradient-to-b from-black via-gray-900 to-black py-4 min-h-[55px] flex items-center justify-between"> |
There was a problem hiding this comment.
Keep the "StarkFinder" name and the Launch App only. And modify the popup for launch App to add the /chat/id, /transactions/id that is already present and add the /devx for the devxstark page to be accessed. Rest looks good!
|
@edidiesky You have closed the PR, is that itentional? Just making sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
The navbar design and color tonality were not befitting for the product idea. So I had to improve on it by adjusting the with and padding of the navbar. The border and the border radius were also put into consideration. I also made changes in the framer-motion transition of the modal by removing the transition from the parent DIV to the child div. The modal layout was also modified and also the respective color tonality of the individual element of the modal.