fix: 🩹 Added missing assertions for Showcase.withWidget() (#515) (#517)

Author: Sahil-Simform

CHANGELOG.md

@@ -18,6 +18,8 @@
   Added controller to manage showcase
 - CHORE [#514](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/514) -
   Bumped dart minimum sdk to 2.19.6
+- Fixed [#515](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/515) - Added
+  missing assertions for `Showcase.withWidget()`.
 
 ## [4.0.1]
 - Fixed [#493](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/493) - ShowCase.withWidget not showing issue 

lib/src/showcase/showcase.dart

@@ -426,15 +426,15 @@ class Showcase extends StatefulWidget {
         ),
         assert(
           onTargetClick == null || disposeOnTap != null,
-          "disposeOnTap is required if you're using onTargetClick",
+          "`disposeOnTap` is required if you're using `onTargetClick`",
         ),
         assert(
           disposeOnTap == null || onTargetClick != null,
-          "onTargetClick is required if you're using disposeOnTap",
+          "`onTargetClick` is required if you're using `disposeOnTap`",
         ),
         assert(
           onBarrierClick == null || disableBarrierInteraction == false,
-          "can't use onBarrierClick & disableBarrierInteraction property at same time",
+          "can't use `onBarrierClick` & `disableBarrierInteraction` property at same time",
         );
 
   /// Creates a Showcase widget with a custom tooltip widget.
@@ -546,9 +546,17 @@ class Showcase extends StatefulWidget {
           overlayOpacity >= 0.0 && overlayOpacity <= 1.0,
           'overlay opacity must be between 0 and 1.',
         ),
+        assert(
+          onTargetClick == null || disposeOnTap != null,
+          "`disposeOnTap` is required if you're using `onTargetClick`",
+        ),
+        assert(
+          disposeOnTap == null || onTargetClick != null,
+          "`onTargetClick` is required if you're using `disposeOnTap`",
+        ),
         assert(
           onBarrierClick == null || disableBarrierInteraction == false,
-          "can't use onBarrierClick & disableBarrierInteraction property at same time",
+          "can't use `onBarrierClick` & `disableBarrierInteraction` property at same time",
         );
 
   @override

lib/src/showcase_widget.dart

@@ -486,10 +486,6 @@ class ShowCaseWidgetState extends State<ShowCaseWidget> {
     required ShowcaseController controller,
     required int showcaseId,
   }) {
-    assert(
-      StackTrace.current.toString().contains('_ShowcaseState'),
-      'This method should only be called from `Showcase` class',
-    );
     _showcaseControllers
         .putIfAbsent(
           key,
@@ -505,22 +501,13 @@ class ShowCaseWidgetState extends State<ShowCaseWidget> {
   void removeShowcaseController({
     required GlobalKey key,
     required int uniqueShowcaseKey,
-  }) {
-    assert(
-      StackTrace.current.toString().contains('_ShowcaseState'),
-      'This method should only be called from `Showcase` class',
-    );
-    _showcaseControllers[key]?.remove(uniqueShowcaseKey);
-  }
+  }) =>
+      _showcaseControllers[key]?.remove(uniqueShowcaseKey);
 
   ShowcaseController getControllerForShowcase({
     required GlobalKey key,
     required int showcaseId,
   }) {
-    assert(
-      StackTrace.current.toString().contains('_ShowcaseState'),
-      'This method should only be called from `Showcase` class',
-    );
     assert(
       _showcaseControllers[key]?[showcaseId] != null,
       'Please register showcase controller first by calling '