Tweaks to Shadeskip, Fixes Psi Insul on Caster, Tweaks to Telegnostic Projection #2376
Conversation
…e-fog-is-going-(away)
RocketBoss360
requested review from
VMSolidus,
sleepyyapril and
Remuchi
as code owners
github-actions
bot
added
Status: Needs Review
SimpleStation14
changed the title
WalkthroughThis set of changes introduces new insulation and component-based restrictions to psionic powers, particularly affecting the Mass Sleep ability and several anomaly actions. Entity prototypes for effects, portals, mobs, and spawners are updated or expanded, with new temporary entities and adjusted despawn times. The MobTelegnosisObserver receives a rework, gaining new powers and descriptors while removing certain components. Spawner logic and entity lifetimes are also refined, and several YAML prototypes are updated to reflect these gameplay and balance adjustments. Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
Resources/Prototypes/Entities/Objects/Misc/kudzu.yml (1)
317-333:⚠️ Potential issueCritical: Missing
descriptionfield on new entityThe
ShadowKudzuTempprototype definesnameandidbut lacks adescription:entry. Most entities include descriptions for UI tooltips and logging. Please add a description to avoid unexpected defaults or missing text.
🧹 Nitpick comments (1)
Resources/Prototypes/Entities/Effects/portal.yml (1)
127-135: Grammar nitpick: Description should have an apostropheThe description reads
Its already closing!—it’s missing the contraction apostrophe. Update to:description: "It's already closing!"to maintain consistency and clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Resources/Audio/Psionics/attributions.ymlis excluded by!Resources/Audio/**and included by noneResources/Audio/Psionics/shadeskip_power.oggis excluded by!**/*.ogg,!Resources/Audio/**and included by none
📒 Files selected for processing (7)
Content.Shared/Psionics/Abilities/MassSleep/MassSleepPowerSystem.cs(1 hunks)Resources/Prototypes/Actions/psionics.yml(5 hunks)Resources/Prototypes/Entities/Effects/bluespace_flash.yml(1 hunks)Resources/Prototypes/Entities/Effects/portal.yml(2 hunks)Resources/Prototypes/Entities/Markers/Spawners/Random/shadowkudzu.yml(1 hunks)Resources/Prototypes/Entities/Mobs/Player/observer.yml(2 hunks)Resources/Prototypes/Entities/Objects/Misc/kudzu.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Test Packaging
- GitHub Check: YAML Linter
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (16)
Resources/Prototypes/Entities/Effects/portal.yml (1)
54-54: Clean configuration: Trailing whitespace removedGreat catch on cleaning up the trailing whitespace after the
PortalBluedefinition. Keeping the YAML tidy prevents unnecessary diffs and parsing issues.Resources/Prototypes/Entities/Objects/Misc/kudzu.yml (1)
315-315: Verify gameplay impact: TimedDespawn reduced to 5sYou’ve shrunk
ShadowkinShadow’s lifetime from 30 to 5 seconds. Ensure this rapid despawn aligns with intended spawn frequency and visual flow in-game.Resources/Prototypes/Entities/Markers/Spawners/Random/shadowkudzu.yml (2)
26-27: Approved: Expanded rarePrototypes listAdding
ArtifactFragmentalongsideMobCatShadowenriches the rare drop table without altering spawn probabilities. Good balance move.
28-60: Approved: New temporary loot spawner prototype
ShadowKudzuLootSpawnerTempcorrectly mirrorsShadowKudzuLootSpawner, swapping inShadowPortalTempand adjusting the rarePrototypes. All parameters align with expectations.Resources/Prototypes/Entities/Effects/bluespace_flash.yml (2)
38-38: Extended effect duration significantly improves visibility.By the Republic's standards, increasing the effect lifetime from 1 to 12 seconds is a tactical improvement, cadet! The extended visual cue provides better feedback to the user when shadeskip is activated. This adjustment aligns with the PR's objective to tweak shadeskip mechanics.
41-41: Sound effect properly themed for ability coherence.Excellent attention to sonic details, officer! Replacing the generic lightning sound with a dedicated shadeskip power sound creates proper thematic consistency. This enhances player immersion and makes the ability's activation more distinct in the chaotic environment of space.
Content.Shared/Psionics/Abilities/MassSleep/MassSleepPowerSystem.cs (1)
22-23: Proper gatekeeping for psionic power usage implemented.Attention, recruit! This addition of a preliminary check before mass sleep execution is a critical security measure. It properly respects the insulation mechanics and prevents unauthorized psionic influence, as any responsible Republic officer would demand.
The early return if the check fails ensures that insulated targets are properly protected from mass sleep effects, aligning with the PR's goal to fix psi insulation on casters.
Resources/Prototypes/Actions/psionics.yml (5)
32-35: Proper insulation blacklisting for mind-affecting powers.By the stars, a proper defense mechanism! Adding a component blacklist to prevent mass sleep from targeting entities with PsionicInsulation and Mindbroken components is a critical fix. This implementation ensures that protected entities maintain their sovereignty against unwanted psychic influence, as per Republic protocols.
241-241: Insulation check added to Shadeskip ability.Attention, cadet! Adding insulation checks to anomaly powers is a necessary security measure. This ensures that psionic insulation is properly respected across all psionic interactions, maintaining consistency in the power system.
251-253: Shadeskip spawn parameters rebalanced.Strategic adjustment to combat parameters noted and approved! Increasing the minimum spawn amount while decreasing the maximum and reducing the range creates a more predictable and balanced tactical deployment. These fine-tuned adjustments will make shadeskip's effects more consistent and reliable in the field.
277-277: Telekinetic Pulse now checks for insulation.Proper combat protocol implementation, ensign! Adding insulation checks to the Telekinetic Pulse ability ensures consistent application of the psionic insulation mechanic. This change aligns with Republic security standards for psychic defense systems.
324-324: Pyrokinetic Flare now respects psionic insulation.Affirmative adjustment to combat protocols! The addition of insulation checks to Pyrokinetic Flare ensures that all anomaly powers consistently respect insulation mechanics. This maintains the integrity of our psionic defense systems against unauthorized mental infiltration.
Resources/Prototypes/Entities/Mobs/Player/observer.yml (4)
145-145: More fitting description for psionic projection.This poetic description upgrade from bland technical jargon to "A soul dancing across the dreamlight" provides appropriate context for crew encountering this entity. Well done, communications officer! Maintaining proper flavor text is essential for immersion in any Republic operation.
166-168: Added appropriate psychognomic descriptor.Attention to detail noted, science officer! The addition of the liminal descriptor accurately reflects the nature of projection entities existing between physical states. This properly categorizes the entity within the psionic taxonomy system.
169-173: Enhanced psionic capabilities for telegnostic projection.Strategic enhancement of operative capabilities, commander! The addition of innate psionic powers (Xenoglossy, Telepathy, and Psychognomy) provides the telegnostic observer with essential tools for effective operation. The comment regarding Xenoglossy indicates thoughtful consideration of future implementation options.
174-174: TelegnosticProjection component now enabled.Proper system activation confirmed! Enabling the TelegnosticProjection component completes the functional implementation of this entity. This change aligns with the PR's objective of tweaking telegnostic projection.
|
Cool PR but you added no description, have a name that’s way too long, and didn’t attribute properly. |
|
Also stealth was there to dull the colors a bit and give it the shimmer description, I’d keep that. Hopefully you removing all its view layers doesn’t mess anything up |
Removing its viewing layers should just mean it cant see ghosts, i will test this, and add the stealth comp back |
confirmed, projection can no longer see Ghosts, or Darkswapped individuals (changed as old Projection had no ability to see Ethereal, could easily be convinced to re-add) |
|
Your media is not viewable/doesn't seem to work. Please fix that and it'll be good to merge. |
Description
Shortens duration of fog made by Shadeskip to 12 seconds so it doesnt last longer than it needs to for an escape, shortens Darkswap's fog tile to last 5 seconds, makes shadeskip's portals dissapear along with it and allowes harmless shadow cats to rarely spawn on cast, Shadeskip additionally a different sound.
Psionic insulation now prevents all psionic powers from being cast
Telegnostic projections can now speak over telepathy, they also have the Psychognosis and xenoglossy for now, their description was also changed
Description.
TODO
Media
Changelog
🆑