Skip to content

Plasmemes Can Now Wear Full Modsuits. #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

Diggy0
Copy link
Contributor

@Diggy0 Diggy0 commented May 3, 2025

Yay

Plasmamen no longer burn when they have a modsuit helmet on.

Literally what it says on the title.

What this PR changes is it adds a type in the YML of the modsuit helmet, that disallows the plasmamen from burning when they equip a helmet piece.

There is a module to fix this issue with plasmamen in 13, so once said modules are implemented we could just add that and revert this.


TODO

  • Completed Task

Media

image

Plasmamen with normal modsuit, no longer burns.


Changelog

🆑

  • tweak: Plasmamen can now wear Modsuit helmets.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels May 3, 2025
@SimpleStation14 SimpleStation14 changed the title Plasmemes can now wear full modsuits. Plasmemes Can Now Wear Full Modsuits. May 3, 2025
@Diggy0
Copy link
Contributor Author

Diggy0 commented May 3, 2025

The oooonly issue I can think about is that even when unsealed the suit still prevents burning?
But at the moment we don't have code or anything that goes "Only apply these components when sealed" as far as I know.

Copy link
Contributor

coderabbitai bot commented May 3, 2025

Walkthrough

The changes update the ClothingModsuitHelmetStandard entity configuration in the modsuit YAML file. Two new components are added: a Tag component with the tags PlasmamanSafe and Envirohelm, and an IgniteFromGasImmunity component specifying immunity for the head part. These modifications enhance the helmet's properties regarding environmental safety and gas ignition immunity.

Changes

File(s) Change Summary
Resources/Prototypes/_Goobstation/Entities/Clothing/Head/modsuit.yml Added Tag component (PlasmamanSafe, Envirohelm) and IgniteFromGasImmunity for head part.

Suggested labels

Changes: YML, Status: Needs Review

Suggested reviewers

  • Remuchi
  • sleepyyapril
  • Timfa2112

Poem

Helmets up, recruits, inspect this gear!
Plasmaman-safe and immune to fear.
No gas will spark upon your head,
Envirohelm tags—enough said!
The Biesel fleet stands ready and proud,
With YAML changes, we say it loud!
🪖✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Resources/Prototypes/_Goobstation/Entities/Clothing/Head/modsuit.yml (1)

128-135: Flag this as a temporary workaround
These entries are a stopgap until the 13-module system is integrated. Please add a TODO comment so we don’t lose track and can remove this once the proper module arrives:

   - type: Tag
     tags:
     - PlasmamanSafe
     - Envirohelm
+  # TODO: Temporary plasmaman immunity workaround—remove when 13 modules are ported.
   - type: IgniteFromGasImmunity
     parts:
     - Head
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b98e5be and ee34cdc.

📒 Files selected for processing (1)
  • Resources/Prototypes/_Goobstation/Entities/Clothing/Head/modsuit.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Build & Test Debug
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: Test Packaging
🔇 Additional comments (2)
Resources/Prototypes/_Goobstation/Entities/Clothing/Head/modsuit.yml (2)

128-131: Add PlasmamanSafe and Envirohelm tags
The new Tag component correctly marks this helmet as safe for plasmamen and compliant with Envirohelm protocols. No sabotage from the human-supremacist Sol Alliance detected here—helmets now bear the proper insignia.


132-135: Grant head ignition immunity
The IgniteFromGasImmunity component is scoped precisely to the Head part, ensuring gas won’t ignite the helmet on plasmamen. Stand by to verify that the engine recognizes and enforces this immunity.

@OldDanceJacket
Copy link
Contributor

Again good for now but likely to have the 13 module that makes them safe for Plas' instead of it just being default.... Probably? Guess we can test what we prefer.

@OldDanceJacket OldDanceJacket merged commit 8344cea into Simple-Station:master May 8, 2025
16 checks passed
SimpleStation14 added a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants