Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings during model binding #30

Open
jballe opened this issue Feb 18, 2025 · 0 comments
Open

Warnings during model binding #30

jballe opened this issue Feb 18, 2025 · 0 comments

Comments

@jballe
Copy link

jballe commented Feb 18, 2025

This line is causing a lot of console output and warnings when using the StarterKit.
I agree that it seems unexpected but should we give a warning? Or maybe it should be something that can be enabled/disabled?

https://github.com/Sitecore/ASP.NET-Core-SDK/blob/44c614011a9344e36624272b3f067017903eae3e/src/Sitecore.AspNetCore.SDK.RenderingEngine/Binding/SitecoreLayoutModelBinder.cs#L55..L60

In the NextJs SDK there are no warnings (and no strong types).

In the StarterKit there are several components that can use either a page/route field or a specific data source aka component field. That has been solved by using multiple fields and hereby the warning is triggered.

https://github.com/Sitecore/xmcloud-starter-dotnet/blob/main/headapps/aspnet-core-starter/Models/PageContent.cs

I would at least suggest that the out-of-the box configuration should not give a lot of warnings.

It might also be that it would be meaningfull with a binding that solves this fallback scenario (use component field if a data source value but fallback to route field) instead of building the logic in the head application over and over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant