Fix/macos installation #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RafaelPalomar
requested review from
pieper and
jcfr
and removed request for
pieper
added 2 commits
April 29, 2025 13:46
ENH: Fix MacOS paths WIP: Simplify installation of Sofa libraries WIP: Include default plugins list
RafaelPalomar
force-pushed
the
fix/macos-installation
branch
from
a2197ef to
c12c741
Compare
jcfr
requested changes
May 6, 2025
| @@ -37,6 +37,7 @@ if(NOT DEFINED ${proj}_DIR AND NOT ${SUPERBUILD_TOPLEVEL_PROJECT}_USE_SYSTEM_${p | |||
| -DCMAKE_CXX_STANDARD:STRING=${CMAKE_CXX_STANDARD} | |||
| -DCMAKE_CXX_STANDARD_REQUIRED:BOOL=${CMAKE_CXX_STANDARD_REQUIRED} | |||
| -DCMAKE_CXX_EXTENSIONS:BOOL=${CMAKE_CXX_EXTENSIONS} | |||
| -DCMAKE_OSX_ARCHITECTURES:STRING=${CMAKE_OSX_ARCHITECTURES} | |||
There was a problem hiding this comment.
Adding this should not be required, instead consider adding ${${proj}_EP_ARGS} to all external project like it is done here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.