Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hue): Fix Mirek -> Kelvin conversion constant. #1934

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(hue): Fix Mirek -> Kelvin conversion constant. #1934

wants to merge 2 commits into from
+28 −1

Conversation

dljsjr
Copy link
Contributor

@dljsjr dljsjr commented Feb 13, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This constant should be 100, but I resolved a conflict during a rebase incorrectly when prepping the original PR and it got set to 11 instead of 100.

Summary of Completed Tests

  • Tested on real devices
  • New Busted tests added to verify behavior at the min/max boundaries.

@github-actions GitHub Actions
Copy link

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/Q1jPNenyNm2L

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Test Results

   64 files  ±0    414 suites  ±0   0s ⏱️ ±0s
2 091 tests ±0  2 091 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 583 runs  ±0  3 583 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 59b1da3. ± Comparison against base commit 9d3589f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 59b1da3

@dljsjr dljsjr force-pushed the fix/hue-incorrect-kelvin-step-size branch from 1368feb to cf090e5 Compare February 13, 2025 20:59
@dljsjr dljsjr requested a review from greens February 13, 2025 20:59
dljsjr added 2 commits March 3, 2025 16:49
@dljsjr
fix(hue): Fix Mirek -> Kelvin conversion constant.
2dac5c2 
This constant should be 100, but I resolved a conflict during a rebase incorrectly
when prepping the original PR and it got set to 11 instead of 100.
@dljsjr
fix: Echo user requested setpoint for kelvin
59b1da3 
If the bulb's color temperature changes because of an ST-initiated user
requested setpoint, we emit that directly instead of clamping to the
step size. This is to remain consistent with the way things are done on
the rest of the platform with other integrations.
@dljsjr dljsjr force-pushed the fix/hue-incorrect-kelvin-step-size branch from cf090e5 to 59b1da3 Compare March 3, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greens greens greens approved these changes

@cjswedes cjswedes cjswedes approved these changes

@NoahCornell NoahCornell NoahCornell approved these changes

@FreeMasen FreeMasen Awaiting requested review from FreeMasen

@kdbang kdbang Awaiting requested review from kdbang

@inasail inasail Awaiting requested review from inasail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dljsjr @greens @cjswedes @NoahCornell