Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thirdreality smart watering kit #1965

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

weihuan1111
Copy link
Contributor

Change-Id: I29859b56237e60dab469b4b4064d10664fcd1027

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Change-Id: I29859b56237e60dab469b4b4064d10664fcd1027
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Feb 27, 2025

Test Results

   65 files    411 suites   0s ⏱️
2 071 tests 2 071 ✅ 0 💤 0 ❌
3 552 runs  3 552 ✅ 0 💤 0 ❌

Results for commit 8e646d0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 27, 2025

File Coverage
All files 72%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-watering-kit/src/thirdreality/init.lua 67%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 8e646d0

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant