Added snowflake connector code to python application observability example #38
Conversation
…o fixed spcs spec.
| @@ -80,14 +81,19 @@ | |||
| callbacks=[lambda options: [Observation(value=len(stock_prices))]] | |||
| ) | |||
|
|
|||
| # Get authorization token from SPCS environment | |||
| def get_login_token(): | |||
| with open('/snowflake/session/token', 'r') as f: | |||
There was a problem hiding this comment.
Can we update README with instructions about how to generate this file? Also, a comment about trace propagation in the README with the corresponding event table queries would be nice.
| conn.commit() | ||
|
|
||
| except Exception as e: | ||
| print(str(e)) |
There was a problem hiding this comment.
Just raise this exception instead of wrapping in print.
| # Alternatively, retrieve the stock price from your Snowflake account | ||
| # The connector library is equipped with trace propagation |
There was a problem hiding this comment.
Can you create a separate endpoint for this? Seems kind of funky to just append this after the alternative way of retrieving this data.
Also, explain at least at a high level why this data is available in the account (pretend that you are a customer reading this documentation. For example:
"Alternatively, the below example shows how you would retrieve data from a Snowflake table. The snowflake.connector library automatically propagates the trace id to snowflake query engine. This ensures that queries generated by Snowflake query engine will be properly nested within this calling function span."
| @@ -80,14 +81,19 @@ | |||
| callbacks=[lambda options: [Observation(value=len(stock_prices))]] | |||
| ) | |||
|
|
|||
| # Get authorization token from SPCS environment | |||
There was a problem hiding this comment.
"Containers managed by Snowpark Container Services makes an oauth login token available at the following path. This token authenticates as the service role, which inherits permissions from the service creator."
Changes
Testing
Notes to reviewers
I tried to integrate the snowflake connector code in a natural way - as an alternative way to retrieve a stock price for a symbol. Let me know if something else would make more sense!