Skip to content

Commit

Permalink
Avoid message box if font load failure during startup (#8610)
Browse files Browse the repository at this point in the history
Move init sys font into GUI_App, after logging has been set up properly (#8603)

This avoid annoying messagebox if somehow failed to load font on windows, and write the message into log files instead
  • Loading branch information
Noisyfox authored Mar 1, 2025
1 parent 00a44ee commit d89520c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/OrcaSlicer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,6 @@ int CLI::run(int argc, char **argv)
bool start_gui = m_actions.empty() && !downward_check;
if (start_gui) {
BOOST_LOG_TRIVIAL(info) << "no action, start gui directly" << std::endl;
::Label::initSysFont();
#ifdef SLIC3R_GUI
/*#if !defined(_WIN32) && !defined(__APPLE__)
// likely some linux / unix system
Expand Down
2 changes: 2 additions & 0 deletions src/slic3r/GUI/GUI_App.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2202,6 +2202,8 @@ bool GUI_App::on_init_inner()
wxLog::SetLogLevel(wxLOG_Message);
#endif

::Label::initSysFont();

// Set initialization of image handlers before any UI actions - See GH issue #7469
wxInitAllImageHandlers();
#ifdef NDEBUG
Expand Down

0 comments on commit d89520c

Please sign in to comment.