-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar margin & spacing fixes #6238
Conversation
@Noisyfox @SoftFever this commit also done only im not sure about how ths change shows on high dpi screens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Fixes unequal spacings and margins on sidebar
Used a class in Plater.cpp to control all spacings from a single file since sidebar is split to 3 files (ParamsPanel.cpp, Plater.cpp, Tab.cpp)
IMPORTANT CHANGES TO CHECK
This changes should be check on high res monitors
• Parameters body text alignment [src/slic3r/GUI/OG_CustomCtrl.cpp]
(https://github.com/SoftFever/OrcaSlicer/pull/6238/files#diff-7fcf2f61c2e06b7e6b295588e3d5039b11dd965ce2491568cc18ff94d3aabe9e)
Line 331
wxCoord h_pos = get_title_width() * m_em_unit + 4;
Titles drawn with StaticLine.cpp and it uses 18px for icon 5px for spacing. Spacing doesnt scales on messureSize()
This line controls alignment of body text on parameters. basically added 4 to fix misalignment. static line element on titlebar using +5 and it looks on on my 2K monitor.
NOTES
EXISTING BUG
• Spacings changing on multiple filaments while it creating second row for that section. Its an existing bug
FIXES
• Most of spacings are not stantardised. Added a standart for them
• No spacing before Machine combo box and Bed type text
• No spacing between "Compare" and "View All Object Settings" icon
• Aligned Parameter texts to it's title text
COMPARISON
Before After
