Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use orca color for "can't find device" link #8298

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

akellbl4
Copy link
Contributor

@akellbl4 akellbl4 commented Feb 3, 2025

Description

Fix text color for "Can't find device?" link in dark mode

Screenshots/Recordings/Graphs

Before

Screenshot 2025-02-03 at 1 37 36 AM

After

Screenshot 2025-02-03 at 11 54 43 AM Screenshot 2025-02-03 at 11 55 07 AM

@akellbl4 akellbl4 changed the title fix cant find printer link color fix: can't find printer link color in dark mode Feb 3, 2025
@yw4z
Copy link
Contributor

yw4z commented Feb 3, 2025

Can you use orca color for it? because its a link that opens in browser like below
Screenshot-20250203124851

@akellbl4 akellbl4 changed the title fix: can't find printer link color in dark mode use orca color for "can't find device" link Feb 3, 2025
@akellbl4
Copy link
Contributor Author

akellbl4 commented Feb 3, 2025

@yw4z done, tested in both light and dark modes. screenshots are updated in description.
I tried to add hover, but couldn't make it work using SetHoverColour()

@yw4z
Copy link
Contributor

yw4z commented Feb 3, 2025

Thanks looks nice, i guess no need to add hover effects. Do have bamboo printer? i have a list some some on UI still uses bamboo green on bamboo related UI sections but i didnt commit because i cant test them. I can share few if you interested

@akellbl4
Copy link
Contributor Author

akellbl4 commented Feb 4, 2025

@yw4z yep, I have a P1S and recently switched to Orca like many others. I saw all same issues in Bambu Studio, but I'd let them fix their problems and much rather support a community driven project.
Send those my way I'll merge them with my list and try to look at it when I have time. I'm not a C++ dev, but I can figure it out :)

@yw4z
Copy link
Contributor

yw4z commented Feb 4, 2025

I have cleaned up many color related (#5712 #5239 ) and UI related issues (#4368 #5221 #6204) over time and still trying to make improvements on it (#8184 #8198)

Here is a list that i couldnt complete

This comment pointed me some missing points but i didnt make a commit since i dont have access to BBL related interfaces
#5712 (comment)

I found few areas that uses BBL color wxColour(0,174,66) to cleanup leftovers

else if (state_device == 1) {
dc.SetTextForeground(wxColour(0,174,66));
DrawTextWithEllipsis(dc, get_state_device(), FromDIP(DEVICE_LEFT_PRO_INFO), left);

Calibration flow text wxColour(0x00, 0xAE, 0x42));

cali_text_right_top->SetForegroundColour(wxColour(0x00, 0xAE, 0x42));

staticline->SetLineColour(wxColour(0x00, 0xAE, 0x42));

AMS window dc.SetPen(wxColour(0x00, 0xAE, 0x42));

dc.SetPen(wxColour(0x00, 0xAE, 0x42));

dc.SetPen(wxColour(0x00, 0xAE, 0x42));

Also should be few icon related issues on BBL interfaces

@akellbl4
Copy link
Contributor Author

akellbl4 commented Feb 4, 2025

@yw4z I'll take a look, swapping colors should be quick.
Ia anything holding off to merge this PR?

@yw4z
Copy link
Contributor

yw4z commented Feb 4, 2025

i assume better to group similar commits. you can check for format on my color commits. few screenshots and explanations would be enough. you can send them as separate commit as well.

I guess only Noisyfox and SoftFever can merge commits right now, and looks like they busy with fixing other things. Since few people reviewing commits it can take time. Thats why i group similar commits

Copy link
Collaborator

@Noisyfox Noisyfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Noisyfox Noisyfox merged commit 8337db2 into SoftFever:main Feb 5, 2025
16 checks passed
GiacomoGuaresi pushed a commit to gingeradditive/OrcaSlicer that referenced this pull request Feb 8, 2025
Co-authored-by: Paul Mineev <paul@mineev.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants