-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use orca color for "can't find device" link #8298
Conversation
@yw4z done, tested in both light and dark modes. screenshots are updated in description. |
Thanks looks nice, i guess no need to add hover effects. Do have bamboo printer? i have a list some some on UI still uses bamboo green on bamboo related UI sections but i didnt commit because i cant test them. I can share few if you interested |
@yw4z yep, I have a P1S and recently switched to Orca like many others. I saw all same issues in Bambu Studio, but I'd let them fix their problems and much rather support a community driven project. |
I have cleaned up many color related (#5712 #5239 ) and UI related issues (#4368 #5221 #6204) over time and still trying to make improvements on it (#8184 #8198) Here is a list that i couldnt complete This comment pointed me some missing points but i didnt make a commit since i dont have access to BBL related interfaces I found few areas that uses BBL color wxColour(0,174,66) to cleanup leftovers OrcaSlicer/src/slic3r/GUI/MultiMachineManagerPage.cpp Lines 178 to 180 in 5e4dd4d
Calibration flow text wxColour(0x00, 0xAE, 0x42)); OrcaSlicer/src/slic3r/GUI/Calibration.cpp Line 118 in 5e4dd4d
OrcaSlicer/src/slic3r/GUI/Calibration.cpp Line 122 in 5e4dd4d
AMS window dc.SetPen(wxColour(0x00, 0xAE, 0x42)); OrcaSlicer/src/slic3r/GUI/AmsMappingPopup.cpp Line 257 in 5e4dd4d
OrcaSlicer/src/slic3r/GUI/AmsMappingPopup.cpp Line 269 in 5e4dd4d
Also should be few icon related issues on BBL interfaces |
@yw4z I'll take a look, swapping colors should be quick. |
i assume better to group similar commits. you can check for format on my color commits. few screenshots and explanations would be enough. you can send them as separate commit as well. I guess only Noisyfox and SoftFever can merge commits right now, and looks like they busy with fixing other things. Since few people reviewing commits it can take time. Thats why i group similar commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Co-authored-by: Paul Mineev <paul@mineev.me>
Description
Fix text color for "Can't find device?" link in dark mode
Screenshots/Recordings/Graphs
Before
After