-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Smooth" outer perimeters #8443
Open
philyeahz
wants to merge
7
commits into
SoftFever:main
Choose a base branch
from
philyeahz:feature/smooth_outline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile keeping internal layer height
That's an interesting idea. These artifacts will probably be less obvious if we print with a 0.3 mm layer height and use 2 outer wall dividers (resulting in 0.15 mm per divider). Is this intended to achieve fast printing while still maintaining a smooth finish? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new parameter called "Outer perimeter layer divider".
This division factor is used to generate sub slices for each layer, which will be used to generate the outer perimeters.
While trying some stuff on the brick layers, I found the need for generating sub slices for slanted walls. Incidentally the outer perimeter "smoothing" could be implemented with this as well.
Not happy with the current state, but it's a start, so someone else could build on it and make it better.
Also tried implementing it the other way around, merging internal layers together,
but adding sub slices to the outer perimeters resulted in less resistance inside the code base.
Screenshots/Recordings/Graphs
Tests
Nozzle: 0.4mm
Layer height: 0.2mm
Outer perimeter layer divider: 2 (Outer perimeter layer height: 0.1mm)
Outer perimeter artifacts are mainly due to inconsistent extrusion speed.
Known Issues