Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text on file/config overwrite dialog #8471

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

afmenez
Copy link
Contributor

@afmenez afmenez commented Feb 20, 2025

Description

Changing "override" to "overwrite". Also, only one of the options was translatable.

Noisyfox
Noisyfox previously approved these changes Feb 21, 2025
Copy link
Collaborator

@Noisyfox Noisyfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Though this could break existing translations, do you mind fixing that too?

@afmenez
Copy link
Contributor Author

afmenez commented Feb 24, 2025

The pt-BR translation is already OK, I wouldn't dare messing with languages which I am not fluent.

@afmenez
Copy link
Contributor Author

afmenez commented Mar 5, 2025

@Noisyfox, do you mean updating the english part of the .pot/.po files?

@Noisyfox
Copy link
Collaborator

Noisyfox commented Mar 5, 2025

@Noisyfox, do you mean updating the english part of the .pot/.po files?

Yes, like what #8652 did.

@afmenez
Copy link
Contributor Author

afmenez commented Mar 5, 2025

Done. I have added the "fuzzy" marker on the translations I didn't understand.

@Noisyfox Noisyfox merged commit 2a5371a into SoftFever:main Mar 5, 2025
8 checks passed
@afmenez afmenez deleted the overwrite_file branch March 5, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants