Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement "Only one wall on top surfaces": better support for interface_shells #8627

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

SoftFever
Copy link
Owner

Description

This PR aims to enhance OrcaSlicer's Only one wall on top surfaces feature.
Previously, walls were incorrectly generated if both interface_shells and only_one_wall_top are enabled where there should be a wall because(Ref to the screenshot)

Screenshots/Recordings/Graphs

onewall

Tests

KayTag_Test.zip

@SoftFever SoftFever merged commit 93cb042 into main Mar 1, 2025
16 checks passed
@SoftFever SoftFever deleted the feature/one_wall_interface_shells branch March 1, 2025 14:22
@liftbag
Copy link

liftbag commented Mar 2, 2025

Good morning. I did this test with the current beta 2. Are these the same artifacts as the previous version?

Registrazione.schermo.2025-03-02.alle.09.16.29.mp4

Embossed text.3mf.zip

@discip
Copy link
Contributor

discip commented Mar 3, 2025

@liftbag
Try this:
image

@liftbag
Copy link

liftbag commented Mar 3, 2025

@liftbag Try this:

Thanks, solved. Did I disable it accidentally, or is it disabled by default?

Screenshot 2025-03-03 alle 17 50 04

@bookledge
Copy link

Description

This PR aims to enhance OrcaSlicer's Only one wall on top surfaces feature. Previously, walls were incorrectly generated if both interface_shells and only_one_wall_top are enabled where there should be a wall because(Ref to the screenshot)

Screenshots/Recordings/Graphs

onewall onewall

Tests

KayTag_Test.zip

loop count 2 makes same artifacts. still something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants